mocha icon indicating copy to clipboard operation
mocha copied to clipboard

Published 20 hours ago • verified publisher icon mochajs

feat: make forbid-only as default on CI

Open JaeHyeonKim19 opened this issue 6 years ago • 5 comments

Description of the Change

  • When process.env.CI is true, forbid-only : true is default value. And I changed one of conditional statements in package-scripts.js to keep its function.

Alternate Designs

  • There're may be a better way, but it's my best. 😂

Why should this be in core?

  • Due to this change, We can prevent pushing to remote repo with .only.

Benefits

  • Due to this change, We can prevent pushing to remote repo with .only.

Possible Drawbacks

  • If this change apply to mocha, Existing users can be confused. Because project which use '.only' on purpose gonna make conflict on CI. So We've to announce about this change when this change is applied.

Applicable issues

  • close #3030

JaeHyeonKim19 avatar Aug 16 '19 08:08 JaeHyeonKim19

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Aug 16 '19 08:08 jsf-clabot

Tests which use a fixture that has .only are failed. In Ci, we should handle this.

outsideris avatar Aug 17 '19 02:08 outsideris

Coverage Status

Coverage increased (+0.03%) to 93.594% when pulling 80e75c81b05edaa2e54f6d6bd04eb48f67ed1bd6 on JaeHyeonKim19:issue/3030 into 63eb80bd4907ac87b5cbde054ad8e6112fdcb939 on mochajs:master.

coveralls avatar Oct 26 '19 08:10 coveralls

Any review😂?

JaeHyeonKim19 avatar Nov 12 '19 08:11 JaeHyeonKim19

👋 coming back to this @JaeHyeonKim19, are you still interested in working on this PR? As of https://github.com/mochajs/mocha/issues/5027 there are again maintainers who can review it now. No worries if you no longer have time - but if you do that'd be great!

(I do see that your last message was asking for review - unless directed otherwise we'll try to review it once we're ramped up enough!)

JoshuaKGoldberg avatar Dec 02 '23 21:12 JoshuaKGoldberg