moby
manager/allocator/cnmallocator: add temporary adaptor for constructor
- possible alternative to https://github.com/moby/moby/pull/45843
- relates to / supersedes / closes https://github.com/moby/swarmkit/pull/3130
- supersedes / closes https://github.com/moby/swarmkit/pull/3015
Add an adaptor to help with a signature change in the Idm constructor.
- What I did
- How I did it
- How to test it
- Description for the changelog
Looks like this has legitimate test failures hitting the "invalid constructor" branch -- but I like this idea in principle, if we can make it work...
Yes, looks like I messed it up, or at least didn't handle everything, but I can give it another try tomorrow
Codecov Report
Merging #3139 (e21d93d) into master (93fe90a) will decrease coverage by
0.08%. The diff coverage is56.25%.
@@ Coverage Diff @@
## master #3139 +/- ##
==========================================
- Coverage 61.76% 61.69% -0.08%
==========================================
Files 154 154
Lines 31106 31120 +14
==========================================
- Hits 19214 19198 -16
- Misses 10346 10383 +37
+ Partials 1546 1539 -7
Whoop; this is green, and my test-PR in moby with this change is also green;
- https://github.com/moby/moby/pull/45876
@dperny @neersighted PTAL
I think I can combine this PR with https://github.com/moby/swarmkit/pull/3015, which now does something very similar for another signature change; let me update this one.
