swarmkit icon indicating copy to clipboard operation
swarmkit copied to clipboard

[WIP] Bump hashicorp deps

Open thaJeztah opened this issue 6 years ago • 4 comments

bump hashicorp/go-memdb v1.0.3

full diff: https://github.com/hashicorp/go-memdb/compare/cb9a474f84cc5e41b273b20c6927680b2a8776ad...v1.0.3

possibly relevant changes:

  • hashicorp/go-memdb#21 Added a new MultiIndexer for map[string]string fields
  • hashicorp/go-memdb#23 Adds support for fine-grained watches
  • hashicorp/go-memdb#25 Delays mutation notifications until after the whole transaction is applied
    • fixes hashicorp/go-memdb#24 Notify channels close early during a commit
  • hashicorp/go-memdb#26 Add a uint indexer
  • hashicorp/go-memdb#31 Fix buffer size when encoding uint fields
  • hashicorp/go-memdb#35 Add DeletePrefix method that allows faster deletes of objects in the id index
  • hashicorp/go-memdb#37 Add WatchCtx function
  • hashicorp/go-memdb#38 WatchCtx returns error
  • hashicorp/go-memdb#39 Add a FilterIterator that wraps a ResultIterator
  • hashicorp/go-memdb#42 use ErrNotFound for deleting missing item
  • hashicorp/go-memdb#50 fix: dereference pointers for String Fields
  • hashicorp/go-memdb#52 fix: allow nil string pointers
  • hashicorp/go-memdb#59 Add Int indexing
  • hashicorp/go-memdb#60 Add CompoundMultiIndexer
  • hashicorp/go-memdb#61 Add LowerBound to allow for index range scans

bump hashicorp/golang-lru v0.5.3

full diff: https://github.com/hashicorp/golang-lru/compare/v0.5.1...v0.5.3

  • hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference
  • hashicorp/golang-lru#57 Adds LRU cache resize
  • hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest

thaJeztah avatar Sep 25 '19 12:09 thaJeztah

hm.. looks like this needs some work and their latest versions don't play well together?

# github.com/docker/swarmkit/vendor/github.com/hashicorp/go-memdb
vendor/github.com/hashicorp/go-memdb/txn.go:623:11: indexIter.SeekLowerBound undefined (type *iradix.Iterator has no field or method SeekLowerBound)
make: *** [bin/swarmd] Error 2
Exited with code 2

thaJeztah avatar Sep 25 '19 12:09 thaJeztah

Ah, it's because of our fork of immutable radix

thaJeztah avatar Sep 25 '19 12:09 thaJeztah

Added a WIP commit to re-vendor immutable radix from my branch; https://github.com/tonistiigi/go-immutable-radix/pull/1

thaJeztah avatar Sep 25 '19 12:09 thaJeztah

Codecov Report

Merging #2905 into master will decrease coverage by 0.11%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
- Coverage    61.7%   61.59%   -0.12%     
==========================================
  Files         139      139              
  Lines       22615    22615              
==========================================
- Hits        13955    13930      -25     
- Misses       7188     7201      +13     
- Partials     1472     1484      +12

codecov[bot] avatar Sep 25 '19 13:09 codecov[bot]

These were updated, so this is no longer needed

thaJeztah avatar Dec 15 '22 16:12 thaJeztah