swarmkit icon indicating copy to clipboard operation
swarmkit copied to clipboard

Refactor allocator to attempt to reduce complexity

Open thaJeztah opened this issue 7 years ago • 8 comments

~This one is built on top of https://github.com/docker/swarmkit/pull/2821~

see individual commits for a description of the changes 🤗

thaJeztah avatar Feb 09 '19 13:02 thaJeztah

@dperny @andrey-ko PTAL

thaJeztah avatar Feb 09 '19 13:02 thaJeztah

Codecov Report

Merging #2823 into master will increase coverage by 0.05%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
+ Coverage   61.62%   61.67%   +0.05%     
==========================================
  Files         139      139              
  Lines       22615    22612       -3     
==========================================
+ Hits        13936    13947      +11     
+ Misses       7194     7185       -9     
+ Partials     1485     1480       -5

codecov[bot] avatar Feb 11 '19 11:02 codecov[bot]

rebased to kick CI again

thaJeztah avatar Apr 12 '19 18:04 thaJeztah

rebased again

thaJeztah avatar Oct 20 '19 12:10 thaJeztah

ping @dani-docker @dperny ptal

thaJeztah avatar Oct 20 '19 12:10 thaJeztah

All 3 LGTM 👍

dani-docker avatar Oct 21 '19 21:10 dani-docker

@dperny ptal

thaJeztah avatar Dec 03 '21 17:12 thaJeztah

Codecov Report

Merging #2823 (b0ee1de) into master (b98a45d) will increase coverage by 0.04%. The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
+ Coverage   61.75%   61.79%   +0.04%     
==========================================
  Files         155      155              
  Lines       31145    31138       -7     
==========================================
+ Hits        19234    19243       +9     
+ Misses      10361    10349      -12     
+ Partials     1550     1546       -4     

codecov-commenter avatar Nov 19 '22 11:11 codecov-commenter