spdystream icon indicating copy to clipboard operation
spdystream copied to clipboard

Fix unit test races (carry #48)

Open thaJeztah opened this issue 3 years ago • 7 comments

carries: https://github.com/moby/spdystream/pull/48 closes https://github.com/moby/spdystream/pull/48

thaJeztah avatar Dec 19 '22 08:12 thaJeztah

CI failure is unrelated; will be fixed by https://github.com/moby/spdystream/pull/90

thaJeztah avatar Dec 19 '22 09:12 thaJeztah

@dims PTAL 🤗

thaJeztah avatar Dec 19 '22 09:12 thaJeztah

hmm, 90 needs one more approval before we can land that and make this go green here

dims avatar Dec 19 '22 12:12 dims

hmm, 90 needs one more approval before we can land that and make this go green here

I, erm, went slightly ahead and got that one in to fix CI 😅 😇

@dmcgowan ptal

thaJeztah avatar Dec 19 '22 12:12 thaJeztah

FWIW; I just noticed that https://github.com/moby/spdystream/pull/86 also has a fix for this, so we could choose to take that one as well (I guess either approach would work)

thaJeztah avatar Dec 19 '22 12:12 thaJeztah

Either is fine, #86 is a bit bigger and think it needs some validation

dmcgowan avatar Dec 20 '22 21:12 dmcgowan

/lgtm

I'm going to close #86 since it should no longer needed

aojea avatar Feb 14 '23 08:02 aojea

@dmcgowan I saw you merged another PR; I rebased this one again to get a fresh run of CI 👍

thaJeztah avatar Jun 21 '24 13:06 thaJeztah