libnetwork icon indicating copy to clipboard operation
libnetwork copied to clipboard

bump hashicorp/memberlist v0.1.4, hashicorp/serf v0.8.3

Open thaJeztah opened this issue 6 years ago • 6 comments

~built on top of https://github.com/docker/libnetwork/pull/2440, but~ keeping this separate as it's a bigger change in dependency, and adds some new ones.

bump hashicorp/memberlist v0.1.4

full diff: https://github.com/hashicorp/memberlist/compare/3d8438da9589e7b608a83ffac1ef8211486bcb7c...v0.1.4

  • hashicorp/memberlist#158 Limit concurrent push/pull connections
  • hashicorp/memberlist#159 Prioritize alive message over other messages
  • hashicorp/memberlist#168 Add go.mod
  • hashicorp/memberlist#167 Various changes to improve the cpu impact of TransmitLimitedQueue in large clusters
  • hashicorp/memberlist#169 added back-off to accept loop to avoid a tight loop
  • hashicorp/memberlist#178 Avoid to take into account wrong versions of protocols in Vsn
  • hashicorp/memberlist#189 Allow a dead node's name to be taken by a new node

bump hashicorp/go-msgpack v0.5.5

full diff: https://github.com/hashicorp/go-msgpack/compare/71c2886f5a673a35f909803f38ece5810165097b...v0.5.5

  • hashicorp/go-msgpack#3 Add go.mod
  • hashicorp/go-msgpack#7 Do not attempt to set unsettable types
  • hashicorp/go-msgpack#8 codec: do not dereference pointers/interfaces for omitempty support
    • backport of https://github.com/hashicorp/go-msgpack/commit/006e1534301cb75b848ee452ab5d3ba8c6a70784
    • backport of https://github.com/hashicorp/go-msgpack/commit/006e1534301cb75b848ee452ab5d3ba8c6a70784
    • fixes https://github.com/ugorji/go/issues/67 "omitempty" fails on pointers to bools

bump hashicorp/serf v0.8.3

full diff https://github.com/hashicorp/serf/compare/598c54895cc5a7b1a24a398d635e8c0ea0959870...v0.8.3

Changelog: https://github.com/hashicorp/serf/blob/v0.8.3/CHANGELOG.md

We were previously 47 commits ahead of v0.7.0 (v0.7.0-47-g598c548), 60 commits behind v0.8.0

  • https://github.com/hashicorp/serf/compare/v0.7.0...598c54895cc5a7b1a24a398d635e8c0ea0959870
  • https://github.com/hashicorp/serf/compare/598c54895cc5a7b1a24a398d635e8c0ea0959870...v0.8.0

bump armon/go-metrics ec5e00d3c878b2a97bbe0884ef45ffd1b4f669f5

full diff: https://github.com/armon/go-metrics/compare/eb0af217e5e9747e41dd5303755356b62d28e3ec...ec5e00d3c878b2a97bbe0884ef45ffd1b4f669f5

thaJeztah avatar Aug 26 '19 11:08 thaJeztah

one failure;

=== RUN   TestNetworkDBCRUDTableEntries
2020/02/26 21:17:43 Closing DB instances...
--- FAIL: TestNetworkDBCRUDTableEntries (7.61s)
    networkdb_test.go:141: Entry existence verification test failed for node2(9dab403365ae)

failure above is difficult to locate, because the error occurs in a helper that's used in many tests. Pushing a commit to mark helper-functions as t.Helper() to see if the output is more usable

thaJeztah avatar Feb 26 '20 21:02 thaJeztah

.....and now it passes of course, LOL. Looks like it's just a flaky test

thaJeztah avatar Feb 26 '20 22:02 thaJeztah

Rebased this PR, and had the same failure as above, so could be related

=== RUN   TestNetworkDBCRUDTableEntries
2021/05/11 12:46:55 Closing DB instances...
--- FAIL: TestNetworkDBCRUDTableEntries (7.61s)
    networkdb_test.go:141: Entry existence verification test failed for node2(4930d64b17a6)

thaJeztah avatar May 11 '21 12:05 thaJeztah

nope; passes again now, so looks to be just flaky

thaJeztah avatar May 11 '21 14:05 thaJeztah

@cpuguy83 @AkihiroSuda @arkodg ptal

thaJeztah avatar May 25 '21 19:05 thaJeztah

Can we hold off until libnetwork is merged into moby?

cpuguy83 avatar May 25 '21 20:05 cpuguy83