libnetwork icon indicating copy to clipboard operation
libnetwork copied to clipboard
verified publisher icon moby

Fix sandbox cleanup

Open fcrisciani opened this issue 8 years ago • 2 comments

Driver and Sanbox have 2 different stores where the endpoints are saved It is possible that the 2 store go out of sync if the endpoint is added to the driver but there is a crash before the sandbox join. On restart now we take the list of endpoints from the network and we assign them back to the sandbox

Signed-off-by: Flavio Crisciani [email protected]

fcrisciani avatar Jun 12 '17 22:06 fcrisciani

besides a small nit, LGTM

vieux avatar Aug 11 '17 00:08 vieux

Hi folks! Not sure what are your plans regarding this PR, but let me share some positive experience we had with it at balena:

  • Historically, we saw the #1790 issue occasionally in some of our users. Recently, however, one customer reported quite frequent occurrences.
  • We fixed the conflicts with recent libnetwork versions. Small stuff, no big deal.
  • We did some work to reproduce the issue and test this patch, with good results. This is described here.
  • So we decided to integrated this PR into balenaEngine.
  • This has been working fine for just over a month now. The one user that was seeing this issue frequently hasn't seen any other case since upgrading.

lmbarros avatar May 29 '23 14:05 lmbarros