buildkit icon indicating copy to clipboard operation
buildkit copied to clipboard
verified publisher icon moby

hack: track helper process coverage in integration tests

Open tonistiigi opened this issue 1 year ago • 4 comments

tonistiigi avatar May 18 '24 01:05 tonistiigi

https://app.codecov.io/gh/moby/buildkit/pull/4938 +20% 👀

crazy-max avatar May 18 '24 13:05 crazy-max

@crazy-max Note that the scanned lines also increased a lot. Covered lines is 3x.

image image

I added a commit for pb.go.

There is still some code with external frontends & dockerfile-labs where the test runs only inside container and no coverage is detected. Looking at codecov, some such files show up with 0 coverage but some are missing completely from report.

tonistiigi avatar May 18 '24 15:05 tonistiigi

image

Not sure if things like these can be fixed by setting some option: image image

tonistiigi avatar May 18 '24 16:05 tonistiigi

Seems "disable_file_fixes" setting didn't change much.

tonistiigi avatar May 20 '24 15:05 tonistiigi

Not sure if things like these can be fixed by setting some option:

Do you mean comments being taken into account? If so don't think this is possible. This is based on go tool covdata output I guess.

crazy-max avatar May 30 '24 15:05 crazy-max