buildkit icon indicating copy to clipboard operation
buildkit copied to clipboard

add loongarch64 support for archutil

Open yzewei opened this issue 1 year ago • 13 comments

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

yzewei avatar Oct 31 '23 11:10 yzewei

I'm not sure if we want to include this in regular release as it does add overhead to detect these architectures that are rarely used. Maybe with a special go build tag?

tonistiigi avatar Oct 31 '23 23:10 tonistiigi

@yzewei Comment from https://github.com/moby/buildkit/pull/4392#pullrequestreview-1707547070 has not been addressed.

tonistiigi avatar Nov 13 '23 21:11 tonistiigi

@yzewei Comment from #4392 (review) has not been addressed.

Thank you for your suggestions and reminders. I have recently provided Loongarch adaptation for Buildkit, in order to complete the work of building mirrors cross -architecture on Loongarch Based on your previous reply, I recently provided Loongarch support for the xx project I do n’t understand what you said to add a special Go Build label. I use xx-go after the xx project is transplanted?

yzewei avatar Nov 14 '23 06:11 yzewei

I recently provided Loongarch support for the xx project

I don't see any new PRs against xx

tonistiigi avatar Nov 14 '23 18:11 tonistiigi

I recently provided Loongarch support for the xx project

I don't see any new PRs against xx

Sorry, I don't think I can express my meaning clearly. I am doing this. I expected to be submitted this week

yzewei avatar Nov 15 '23 00:11 yzewei

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

The PR has been submitted. Thank you for your support in building the ecosystem for the Loongarch architecture! xx-PR

yzewei avatar Dec 05 '23 08:12 yzewei

squash commits to 1

yzewei avatar Dec 22 '23 02:12 yzewei

PTAL

yzewei avatar Jan 09 '24 08:01 yzewei

What other questions?

yzewei avatar Jan 12 '24 08:01 yzewei

Is there any problem with this PR?

yzewei avatar Jan 15 '24 10:01 yzewei

@yzewei Needs rebase related to changes from https://github.com/moby/buildkit/pull/4607. This should kick ci and validate archutil.

EDIT: rebased myself and pushed changes.

crazy-max avatar Feb 09 '24 21:02 crazy-max

@yzewei Seems aarch64 package does not exist from previous comment, see: https://github.com/moby/buildkit/actions/runs/7868985167/job/21467181513?pr=4392#step:5:252

#14 7.644 Fetched 9268 kB in 7s (1284 kB/s)
#14 7.644 Reading package lists...
#14 26.25 Reading package lists...
#14 44.69 Building dependency tree...
#14 49.04 Reading state information...
#14 49.10 E: Unable to locate package binutils-loongarch64-linux-gnu

You can try locally with docker buildx bake validate-archutil --set "*.platform=linux/arm64"

crazy-max avatar Feb 12 '24 08:02 crazy-max

binutils-loongarch64-linux-gnu

Sorry, you are right. The debian image in the arm architecture does not have this toolkit. What else do I need to do? As the debian community improves its support for the loongarch architecture, more architecture support should be added in the future, such as aarch64 Can we currently only verify the amd64 architecture and temporarily block the arm64 architecture?

yzewei avatar Feb 18 '24 01:02 yzewei