buildkit icon indicating copy to clipboard operation
buildkit copied to clipboard
verified publisher icon moby

fix(client): use grpc-go default dialer for tcp and unix connections

Open hown3d opened this issue 2 years ago • 5 comments

Closes #4126.

hown3d avatar Aug 08 '23 19:08 hown3d

I think this seems good to me in principle. Though maybe @tonistiigi or @crazy-max have additional context for why we use a custom dialer here, instead of just using the default.

jedevc avatar Aug 09 '23 09:08 jedevc

Is there something missing to review this PR?

hown3d avatar Jan 31 '24 10:01 hown3d

Closing/re-opening to kick CI to rerun against master (since this has been open a while).

Looks like linting is now failing (sorry).

jedevc avatar Jan 31 '24 10:01 jedevc

Rebased.

jedevc avatar Feb 27 '24 16:02 jedevc

Note: this probably shouldn't be for v0.13.0.

jedevc avatar Feb 27 '24 16:02 jedevc

Squashed commits + rebased, and merged :tada:

jedevc avatar Mar 18 '24 15:03 jedevc