buildkit icon indicating copy to clipboard operation
buildkit copied to clipboard

Missing a buildkit release compatible with buildx 0.9.1

Open gerhard opened this issue 3 years ago • 3 comments

buildx v0.9.1 was released last week. It bumps the https://github.com/tonistiigi/fsutil dependency to github.com/tonistiigi/fsutil v0.0.0-20220510150904-0dbf3a8a7d58

Since there is currently no released version of buildkit with the same dependency, this is the error when bumping buildx to v0.9.1:

# github.com/moby/buildkit/session/filesync
../../../go/pkg/mod/github.com/moby/[email protected]/session/filesync/filesync.go:112:20: cannot use dir.Map (variable of type func(string, *types.Stat) bool) as type fsutil.MapFunc in struct literal

If we bump buildkit to current dev github.com/moby/buildkit v0.10.1-0.20220822001651-b50172ef0353, this is the error that we get:

5:38PM ERROR failed to pull buildkit image: exit status 1    output=Error response from daemon: manifest for moby/buildkit:v0.10.1-0.20220822001651-b50172ef0353 not found: manifest unknown: manifest unknown
 version=v0.10.1-0.20220822001651-b50172ef0353
5:38PM FATAL unable to create client: exit status 1

Is it reasonable to expect a new BuildKit version sometimes this week? Thank you!


re https://github.com/dagger/dagger/pull/2956 cc @sipsma

gerhard avatar Aug 22 '22 16:08 gerhard

Is it reasonable to expect a new BuildKit version sometimes this week?

No, there is no major release of BuildKit planned in the next weeks.

You should use the commit that is included in buildx for importing.

tonistiigi avatar Aug 22 '22 20:08 tonistiigi

@tonistiigi No, there is no major release of BuildKit planned in the next weeks.

Thank you for v0.10.4, that might just fix this.

@tonistiigi You should use the commit that is included in buildx for importing.

That's what lead me to create this issue: https://github.com/dagger/dagger/pull/2956#issuecomment-1222583392. Did you mean something else?

I am going to check if v0.10.4 resolves this issue. If it does, I will close this.

Thanks @tonistiigi!

gerhard avatar Aug 23 '22 10:08 gerhard

buildx v0.9.1 is incompatible with buildkit v0.10.4 when both are used as a library, as we are here: https://github.com/dagger/dagger/blob/v0.2.30/go.mod

https://github.com/moby/buildkit/blob/v0.10.4/go.mod#L52 references github.com/tonistiigi/fsutil v0.0.0-20220115021204-b19f7f9cb274

https://github.com/docker/buildx/blob/v0.9.1/go.mod#L119 references github.com/tonistiigi/fsutil v0.0.0-20220510150904-0dbf3a8a7d58

gerhard avatar Aug 23 '22 16:08 gerhard