buildkit icon indicating copy to clipboard operation
buildkit copied to clipboard

Published 20 hours ago • verified publisher icon moby

Is gckeepstorage in bytes or MB?

Open drdivano opened this issue 3 years ago • 1 comments

I tried running buildkit 0.9.3 with several different values of gckeepstorage. Observed that with gckeepstorage=10000000000 disk utilization stays near 10 GB.

Can it be that this PR is wrong, and gckeepstorage is in bytes, not MB, after all? - https://github.com/moby/buildkit/pull/1979

drdivano avatar Jun 21 '22 13:06 drdivano

😞 iiuc then gckeepstorage in config is indeed bytes, while --oci-worker-gc-keepstorage is in MB. I guess the reason is that one was added later and MB made more sense (I do recall that toml library had trouble with float/int mixing as well). Hard to change it now unless we just invent a new field.

But yes, looks like https://github.com/moby/buildkit/pull/1979 should be reverted.

tonistiigi avatar Jun 22 '22 00:06 tonistiigi

I was recently deceived by this documentation so I've submitted a pull request to fix it in hopes of saving others from my fate.

dancysoft avatar Sep 18 '23 17:09 dancysoft