mobx icon indicating copy to clipboard operation
mobx copied to clipboard

Fix devDependencies version duplication in monorepo

Open vovsemenv opened this issue 1 year ago • 2 comments

This PR fix some problems with deps versions in monorepo Linted via https://www.npmjs.com/package/sherif

  mobx git:(main) npx sherif --fix
✓ Select the version of @babel/core to use: ^7.16.0   ↑ highest
✓ Select the version of @babel/preset-env to use: ^7.16.4   ↑ highest

1 issue found in ./package.json:

 ⨯ error The root package.json should specify the package manager and version to use. Useful for tools like corepack. root-package-manager-field
  │ {
  +   "packageManager": "..."   ← missing packageManager field.
  │ }

1 issue found in ./packages/mobx/package.json:

 ✓ fixed package.json should not have empty dependencies fields. empty-dependencies
  │ {
  -   "dependencies": {}   ← field is empty.
  │ }

2 issues found in ./:

 ✓ fixed Dependency @babel/core has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      mobx                      ^7.9.0   ↓ lowest
      mobx-undecorate           ^7.9.0   ↓ lowest
      eslint-plugin-mobx        ^7.16.0   ↑ highest

 ✓ fixed Dependency @babel/preset-env has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      mobx                      ^7.9.5   ↓ lowest
      mobx-undecorate           ^7.9.5   ↓ lowest
      eslint-plugin-mobx        ^7.16.4   ↑ highest

4 issues found (1 ⨯, 0 ⚠️, 3 ✓) across 5 packages in 3.20526775s.
 Note: use `-i` to ignore dependencies, `-r` to ignore rules, `-p` to ignore packages, and `--fix` to autofix fixable issues.

Code change checklist

  • [ ] Added/updated unit tests
  • [ ] Updated /docs. For new functionality, at least API.md should be updated
  • [ ] Verified that there is no significant performance drop (yarn mobx test:performance)

vovsemenv avatar Jul 01 '24 06:07 vovsemenv

⚠️ No Changeset found

Latest commit: a59ec22eb5295465bd81647f97be7d2ae2a75527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 01 '24 06:07 changeset-bot[bot]

This PR seems to cause some failures.

mweststrate avatar Jul 01 '24 21:07 mweststrate