mobx icon indicating copy to clipboard operation
mobx copied to clipboard

Separate Provider/inject from package

Open mweststrate opened this issue 6 years ago • 1 comments

See also mobxjs/mobx-react#640

  • [ ] separate propTypes into separate package
  • [ ] move Provider / inject into separate page

This release is not scheduled yet


Explanation: The reason why this is not done in mobx-react 6 is that it would create a snowball effect migration: "I want to upgrade to react 16.8 to use hooks" -> I need to upgrade to mobx-react 6" -> "Oh, now I need to refactor propTypes and provider / inject" .

So to keep the upgrade path friendly, let's separate these goals:

  • mobx-react@6: Add support for hooks, increase minimum supported version to React 16.8
  • mobx-react@7: Make mobx-react more lean and mean

mweststrate avatar Mar 21 '19 12:03 mweststrate

Are you sure that changing import is such a huge burden? As long as the API stays the same, it's pretty much fixable by find and replace or a simple codemod.

Either way, I think that V6 should include deprecated messages and make those new packages now so people can actually start migrating and not to wait for V7 dropping a bomb :)

danielkcz avatar Mar 22 '19 07:03 danielkcz