mobx.dart
mobx.dart copied to clipboard
test: action should wrap in transaction
Signed-off-by: Minsu Lee [email protected]
https://github.com/mobxjs/mobx/blob/63698d0681988194bac5fc01851882b417b35f18/packages/mobx/tests/v5/base/action.js#L4
Pull Request Checklist
- [x] If the changes are being made to code, ensure the version in
pubspec.yaml
is updated. - [x] Increment the
major
/minor
/patch
/patch-count
, depending on the complexity of change - [x] Add the necessary unit tests to ensure the coverage does not drop
- [x] Update the Changelog to include all changes made in this PR
- [x] Run the
set:versions
command usingnpm
oryarn
. You can find this command in thepackage.json
file in the root directory - [x] Include the necessary reviewers for the PR
- [x] Update the docs if there are any API changes or additions to functionality
Deploy Preview for mobx canceled.
Name | Link |
---|---|
Latest commit | 5f97c5d11b7118a94991c8d34d871538b26be467 |
Latest deploy log | https://app.netlify.com/sites/mobx/deploys/62f06c73a20cbe000802a571 |
Codecov Report
Merging #833 (f6da5c1) into master (4395c8c) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 55 55
Lines 1924 1924
=======================================
Hits 1904 1904
Misses 20 20
Flag | Coverage Δ | |
---|---|---|
flutter_mobx | 100.00% <ø> (ø) |
|
mobx | 98.53% <ø> (ø) |
|
mobx_codegen | 100.00% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4395c8c...f6da5c1. Read the comment docs.
Hi all,
What's stopping this from being merged at the moment?
Thanks, Gavin.