BitcoinChecker
BitcoinChecker copied to clipboard
mobnetic
Parsing error for Dash/Euro on Kraken
Due to this parsing error unable to receive any dash price in euro from this app. I tried deleting and adding this pair, problem persists. Even a 'synchronize now' of update currency pairs produce this parsing error
Android app version : 1.16
Same issue for other pairs such as BTC/EUR, ETH/EUR and LTC/EUR on Kraken. The request is being sent correctly and it receives a response but it can't interpret it correctly. This had only started very recently.
I'm running app version 1.12, responses from before and after the issue started are below:
Old:
{ "error": [], "result": { "XXBTZEUR": { "a": [ "3474.50000", "2", "2.000" ], "b": [ "3474.20000", "1", "1.000" ], "c": [ "3474.40000", "0.27777780" ], "v": [ "3546.28350665", "3681.09831440" ], "p": [ "3462.09009", "3461.82341" ], "t": [ 13939, 14721 ], "l": [ "3442.20000", "3442.20000" ], "h": [ "3484.80000", "3484.80000" ], "o": "3458.20000" } } }
New:
{ "error": [], "result": { "XXBTZEUR": { "a": [ "9318.00000", "3", "3.000" ], "b": [ "9317.60000", "1", "1.000" ], "c": [ "9318.00000", "0.00370288" ], "v": [ "527.45204820", "3962.67692478" ], "p": [ "9341.69074", "9322.39287" ], "t": [ 3081, 19440 ], "l": [ "9283.00000", "9166.00000" ], "h": [ "9445.00000", "9455.00000" ], "o": "9440.40000" } } }
Kraken (now?) returns the header content-encoding as lower case.
I believe RFC says header are case-insensitive, so code should be changed accordingly to support lower and upper case.
https://github.com/mobnetic/BitcoinChecker/blob/master/dataModuleTester/src/main/java/com/mobnetic/coinguardiandatamodule/tester/volley/generic/GzipVolleyRequest.java#L110
@CedricCabessa I added and tested your recommendation. With the new changes, price data is synchronized again. Thank you for outlining the location of the issue.
Could someone publish an apk? Or Robert, could you put a release apk on your repo? Thank you!
@CedricCabessa I added and tested your recommendation. With the new changes, price data is synchronized again. Thank you for outlining the location of the issue.
Could you please provide some help regarding the issue? Thank you!
I created a pull request for fixing the issue so the fix becomes part of the app. But it needs to be approved and accepted first.
I was not familiar with the procedure. I thought it was possible to make changes to the application freely.
Thank You!
Why is there no updated apk since 15 days there is a fix... really bad work I liked the app
Let's not forget to be grateful for a free app, but it's well over a month since the issue was solved and no new APK has been published. Approval and acceptance does not take so long for a fix, so perhaps we should assume the developer will not maintain the app.
Yeah unfortunately this nice app seems dead :( @MaciejCiemiega can you confirm this repo is unmaintained?
i have been using this app for very long time and indeed the developer has not been updating the app. the last updated version in google play was more than 1 year ago.
hopefully someone can take over this project. don't mind donating though
