Avoid unneeded interpolation in map_to_superrest_frame
Hi @moble & @duetosymmetry. I have replaced the interpolation with slicing in the map_to_superrest_frame function. Also, I spotted two typos in the description that I changed. This branch is rebased on top of the previous slicing-abd branch. Please review the PR.
This PR is dependent on #101 (@moble, do you have a label?)
@akhairna a better name for this PR would be "Avoid unneeded interpolation in map_to_superrest_frame"
@keefemitman, Aniket found that the parameter fix_time_phase_freedom is just not used in map_to_superrest_frame. Was it supposed to be used for something? Instead of Aniket's documentation fix, we could just remove the parameter...
Ah no this is suppose to call sxs.waveforms.alignment.align2d, but it looks like I never submitted a PR for this change which I had made locally. I'll submit a PR to do this tomorrow.
This looks like it replaces #101, no?
Yes, there would be some conflicts. I will be rebasing my commit on top of @keefemitman 's PR. Then my PR will be ready to review.
#101 is not Keefe's PR, it is Aniket's earlier PR. The first two commits of this PR are the two commits from #101 (Aniket's original commit, plug Mike's merge commit). If #101 is merged, then this PR is atomic, just getting rid of interpolation when slicing could be used. @moble up to you if you want to review/merge them separately, or treat this as replacing #101.