Added the missing node text for the textarea in the view hierarchy
Proposed changes
copilot:summary
Testing
text attribute for the resource Id "resource-id" : "APjFqb" started getting displayed after the change.
Before changes:
After changes:
Issues fixed
https://github.com/mobile-dev-inc/Maestro/issues/2826
Thanks! This looks to fix an obvious oversight!
Is there anywhere to add a test for this, to demonstrate that the change works?
Thanks! This looks to fix an obvious oversight!
Is there anywhere to add a test for this, to demonstrate that the change works?
I just added the screenshots to this PR with my test results.
Simple way to test is load https://www.google.com in the chrome and compare the value of maestro.viewHierarchy().root for the search input text element which is the textarea or any other website with textarea.
Sorry, I meant a unit or integration test, somewhere in the code. That way we'll also make sure it doesn't break again in the future.
Sure. I will add some test cases for the same.
Thanks! If you get stuck, do shout up here, or come chat on Maestro's Slack - https://slack.maestro.dev
@dineshvenugopal Let me know if you're stuck on implementation, or stuck for time, and I'll try to lend a hand
@dineshvenugopal Let me know if you're stuck on implementation, or stuck for time, and I'll try to lend a hand
Hey @Fishbowler, I am stuck for time. If you could lend a hand on covering tests it will be nice.
On it. I've got a web e2e implementation started in #2867 Once that's in, adding a test for a textarea is trivial.