maestro icon indicating copy to clipboard operation
maestro copied to clipboard

Published 20 hours ago • verified publisher icon mobile-dev-inc

Allow env values in `setLocation` and `travel` commands

Open prasanta-biswas opened this issue 1 year ago • 4 comments

Proposed Changes

Fixes an issue where setLocation command fails if latitude and longitude values are passed from environment variables.

Testing

  • Ran integration tests using ./gradlew :maestro-test:test, all tests passed.
  • Manually tested setLocation command by passing latitude and longitude as env parameters from the command line and within the flow file using the env keyword. It worked for both inline-defined latitude and longitude and passed from env.

Issues Fixed

fixes #1765

prasanta-biswas avatar Jun 18 '24 13:06 prasanta-biswas

@prasanta-biswas thank you! I was about to open a PR solving this exact same issue

Alaksion avatar Jun 18 '24 16:06 Alaksion

Hello @prasanta-biswas Build is failing. Could you please try running build and installDist and make sure they are passing?

  • ./gradlew installDist
  • ./gradlew clean build
* What went wrong:
Execution failed for task ':didb:compileKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

lucaswiechmann avatar Jun 20 '24 19:06 lucaswiechmann

Hi @lucaswiechmann It also failed in my local due to a reflection error in maestro-android. I was using JDK 17 hence the error. However, the build passed when I changed my JDK to 1.8.

Here is the build log

11:46:48 am: Executing 'build'...

> Task :compileKotlin NO-SOURCE
> Task :compileJava NO-SOURCE
> Task :processResources NO-SOURCE
> Task :classes UP-TO-DATE
> Task :jar UP-TO-DATE
> Task :inspectClassesForKotlinIC
> Task :assemble UP-TO-DATE
> Task :detekt NO-SOURCE
> Task :compileTestKotlin NO-SOURCE
> Task :compileTestJava NO-SOURCE
> Task :processTestResources NO-SOURCE
> Task :testClasses UP-TO-DATE
> Task :test NO-SOURCE
> Task :check UP-TO-DATE
> Task :build UP-TO-DATE
> Task :maestro-android:preBuild UP-TO-DATE
> Task :maestro-android:preDebugBuild UP-TO-DATE
> Task :maestro-android:compileDebugAidl NO-SOURCE
> Task :maestro-android:compileDebugRenderscript NO-SOURCE
> Task :maestro-android:generateDebugBuildConfig UP-TO-DATE
> Task :maestro-android:extractDebugProto UP-TO-DATE
> Task :maestro-android:extractIncludeDebugProto UP-TO-DATE
> Task :maestro-proto:compileJava NO-SOURCE
> Task :maestro-proto:processResources NO-SOURCE
> Task :maestro-proto:classes UP-TO-DATE
> Task :maestro-proto:jar UP-TO-DATE
> Task :maestro-android:extractProto UP-TO-DATE
> Task :maestro-android:generateDebugProto UP-TO-DATE
> Task :maestro-android:checkDebugAarMetadata UP-TO-DATE
> Task :maestro-android:generateDebugResValues UP-TO-DATE
> Task :maestro-android:generateDebugResources UP-TO-DATE
> Task :maestro-android:mergeDebugResources UP-TO-DATE
> Task :maestro-android:createDebugCompatibleScreenManifests UP-TO-DATE
> Task :maestro-android:extractDeepLinksDebug UP-TO-DATE
> Task :maestro-android:processDebugMainManifest UP-TO-DATE
> Task :maestro-android:processDebugManifest UP-TO-DATE
> Task :maestro-android:processDebugManifestForPackage UP-TO-DATE
> Task :maestro-android:processDebugResources UP-TO-DATE
> Task :maestro-android:compileDebugKotlin UP-TO-DATE
> Task :maestro-android:javaPreCompileDebug UP-TO-DATE
> Task :maestro-android:compileDebugJavaWithJavac UP-TO-DATE
> Task :maestro-android:compileDebugSources UP-TO-DATE
> Task :maestro-android:mergeDebugNativeDebugMetadata NO-SOURCE
> Task :maestro-android:mergeDebugShaders UP-TO-DATE
> Task :maestro-android:compileDebugShaders NO-SOURCE
> Task :maestro-android:generateDebugAssets UP-TO-DATE
> Task :maestro-android:mergeDebugAssets UP-TO-DATE
> Task :maestro-android:compressDebugAssets UP-TO-DATE
> Task :maestro-android:processDebugJavaRes NO-SOURCE
> Task :maestro-android:mergeDebugJavaResource UP-TO-DATE
> Task :maestro-android:checkDebugDuplicateClasses UP-TO-DATE
> Task :maestro-android:desugarDebugFileDependencies UP-TO-DATE
> Task :maestro-android:mergeExtDexDebug UP-TO-DATE
> Task :maestro-android:mergeLibDexDebug UP-TO-DATE
> Task :maestro-android:dexBuilderDebug UP-TO-DATE
> Task :maestro-android:mergeProjectDexDebug UP-TO-DATE
> Task :maestro-android:mergeDebugJniLibFolders UP-TO-DATE
> Task :maestro-android:mergeDebugNativeLibs UP-TO-DATE
> Task :maestro-android:stripDebugDebugSymbols NO-SOURCE
> Task :maestro-android:validateSigningDebug UP-TO-DATE
> Task :maestro-android:writeDebugAppMetadata UP-TO-DATE
> Task :maestro-android:writeDebugSigningConfigVersions UP-TO-DATE
> Task :maestro-android:packageDebug UP-TO-DATE
> Task :maestro-android:assembleDebug UP-TO-DATE
> Task :maestro-android:preReleaseBuild UP-TO-DATE
> Task :maestro-android:compileReleaseAidl NO-SOURCE
> Task :maestro-android:compileReleaseRenderscript NO-SOURCE
> Task :maestro-android:generateReleaseBuildConfig UP-TO-DATE
> Task :maestro-android:extractIncludeReleaseProto UP-TO-DATE
> Task :maestro-android:extractReleaseProto UP-TO-DATE
> Task :maestro-android:generateReleaseProto UP-TO-DATE
> Task :maestro-android:checkReleaseAarMetadata UP-TO-DATE
> Task :maestro-android:generateReleaseResValues UP-TO-DATE
> Task :maestro-android:generateReleaseResources UP-TO-DATE
> Task :maestro-android:mergeReleaseResources UP-TO-DATE
> Task :maestro-android:createReleaseCompatibleScreenManifests UP-TO-DATE
> Task :maestro-android:extractDeepLinksRelease UP-TO-DATE
> Task :maestro-android:processReleaseMainManifest UP-TO-DATE
> Task :maestro-android:processReleaseManifest UP-TO-DATE
> Task :maestro-android:processReleaseManifestForPackage UP-TO-DATE
> Task :maestro-android:processReleaseResources UP-TO-DATE
> Task :maestro-android:compileReleaseKotlin UP-TO-DATE
> Task :maestro-android:javaPreCompileRelease UP-TO-DATE
> Task :maestro-android:writeReleaseApplicationId UP-TO-DATE
> Task :maestro-android:analyticsRecordingRelease
> Task :maestro-android:compileReleaseJavaWithJavac UP-TO-DATE
> Task :maestro-android:compileReleaseSources UP-TO-DATE
> Task :maestro-android:buildKotlinToolingMetadata UP-TO-DATE
> Task :maestro-android:lintVitalRelease SKIPPED
> Task :maestro-android:mergeReleaseJniLibFolders UP-TO-DATE
> Task :maestro-android:mergeReleaseNativeLibs UP-TO-DATE
> Task :maestro-android:stripReleaseDebugSymbols NO-SOURCE
> Task :maestro-android:extractReleaseNativeSymbolTables NO-SOURCE
> Task :maestro-android:mergeReleaseNativeDebugMetadata NO-SOURCE
> Task :maestro-android:mergeReleaseShaders UP-TO-DATE
> Task :maestro-android:compileReleaseShaders NO-SOURCE
> Task :maestro-android:generateReleaseAssets UP-TO-DATE
> Task :maestro-android:mergeReleaseAssets UP-TO-DATE
> Task :maestro-android:compressReleaseAssets UP-TO-DATE
> Task :maestro-android:checkReleaseDuplicateClasses UP-TO-DATE
> Task :maestro-android:dexBuilderRelease UP-TO-DATE
> Task :maestro-android:desugarReleaseFileDependencies UP-TO-DATE
> Task :maestro-android:mergeExtDexRelease UP-TO-DATE
> Task :maestro-android:mergeDexRelease UP-TO-DATE
> Task :maestro-android:processReleaseJavaRes NO-SOURCE
> Task :maestro-android:mergeReleaseJavaResource UP-TO-DATE
> Task :maestro-android:optimizeReleaseResources UP-TO-DATE
> Task :maestro-android:collectReleaseDependencies UP-TO-DATE
> Task :maestro-android:sdkReleaseDependencyData UP-TO-DATE
> Task :maestro-android:writeReleaseAppMetadata UP-TO-DATE
> Task :maestro-android:writeReleaseSigningConfigVersions UP-TO-DATE
> Task :maestro-android:packageRelease UP-TO-DATE
> Task :maestro-android:assembleRelease UP-TO-DATE
> Task :maestro-android:assemble UP-TO-DATE
> Task :maestro-android:copyMaestroAndroid UP-TO-DATE
> Task :maestro-android:lint SKIPPED
> Task :maestro-android:bundleDebugClasses UP-TO-DATE
> Task :maestro-android:extractIncludeDebugUnitTestProto UP-TO-DATE
> Task :maestro-android:extractTestDebugProto UP-TO-DATE
> Task :maestro-android:extractTestProto UP-TO-DATE
> Task :maestro-android:generateDebugUnitTestProto NO-SOURCE
> Task :maestro-android:compileDebugUnitTestKotlin NO-SOURCE
> Task :maestro-android:preDebugUnitTestBuild UP-TO-DATE
> Task :maestro-android:javaPreCompileDebugUnitTest UP-TO-DATE
> Task :maestro-android:compileDebugUnitTestJavaWithJavac NO-SOURCE
> Task :maestro-android:processDebugUnitTestJavaRes NO-SOURCE
> Task :maestro-android:testDebugUnitTest NO-SOURCE
> Task :maestro-android:bundleReleaseClasses UP-TO-DATE
> Task :maestro-android:extractIncludeReleaseUnitTestProto UP-TO-DATE
> Task :maestro-android:extractTestReleaseProto UP-TO-DATE
> Task :maestro-android:generateReleaseUnitTestProto NO-SOURCE
> Task :maestro-android:compileReleaseUnitTestKotlin NO-SOURCE
> Task :maestro-android:preReleaseUnitTestBuild UP-TO-DATE
> Task :maestro-android:javaPreCompileReleaseUnitTest UP-TO-DATE
> Task :maestro-android:compileReleaseUnitTestJavaWithJavac NO-SOURCE
> Task :maestro-android:processReleaseUnitTestJavaRes NO-SOURCE
> Task :maestro-android:testReleaseUnitTest NO-SOURCE
> Task :maestro-android:test UP-TO-DATE
> Task :maestro-android:check UP-TO-DATE
> Task :maestro-android:build UP-TO-DATE
> Task :maestro-utils:processResources NO-SOURCE
> Task :maestro-ios-driver:processResources
> Task :maestro-ios:processResources NO-SOURCE
> Task :maestro-client:extractProto

> Task :maestro-client:processResources
Execution optimizations have been disabled for task ':maestro-client:processResources' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/prasantabiswas/git/maestro/maestro-client/src/main/resources'. Reason: Task ':maestro-client:processResources' uses this output of task ':maestro-android:copyMaestroAndroid' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :maestro-orchestra-models:processResources NO-SOURCE
> Task :maestro-orchestra:processResources NO-SOURCE
> Task :maestro-utils:compileKotlin
> Task :maestro-studio:web:deps UP-TO-DATE
> Task :maestro-utils:compileJava NO-SOURCE
> Task :maestro-utils:classes UP-TO-DATE
> Task :maestro-utils:jar
> Task :maestro-utils:inspectClassesForKotlinIC
> Task :maestro-studio:web:build UP-TO-DATE
> Task :maestro-studio:server:copyWebFiles UP-TO-DATE

> Task :maestro-studio:server:processResources
Execution optimizations have been disabled for task ':maestro-studio:server:processResources' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/prasantabiswas/git/maestro/maestro-studio/server/src/main/resources'. Reason: Task ':maestro-studio:server:processResources' uses this output of task ':maestro-studio:server:copyWebFiles' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :maestro-cli:processResources
> Task :maestro-cli:createProperties
> Task :maestro-cli:processTestResources NO-SOURCE
> Task :maestro-client:extractTestProto
> Task :maestro-client:processTestResources
> Task :maestro-ios:processTestResources NO-SOURCE
> Task :maestro-ios-driver:processTestResources NO-SOURCE
> Task :maestro-orchestra:processTestResources
> Task :maestro-orchestra-models:processTestResources NO-SOURCE
> Task :maestro-proto:assemble UP-TO-DATE
> Task :maestro-proto:compileTestJava NO-SOURCE
> Task :maestro-proto:processTestResources NO-SOURCE
> Task :maestro-proto:testClasses UP-TO-DATE
> Task :maestro-proto:test NO-SOURCE
> Task :maestro-proto:check UP-TO-DATE
> Task :maestro-proto:build UP-TO-DATE
> Task :maestro-test:processResources NO-SOURCE
> Task :maestro-test:processTestResources
> Task :maestro-utils:assemble
> Task :maestro-utils:compileTestKotlin NO-SOURCE
> Task :maestro-utils:compileTestJava NO-SOURCE
> Task :maestro-utils:processTestResources NO-SOURCE
> Task :maestro-utils:testClasses UP-TO-DATE
> Task :maestro-utils:test NO-SOURCE
> Task :maestro-utils:check UP-TO-DATE
> Task :maestro-utils:build
> Task :maestro-studio:server:processTestResources NO-SOURCE

> Task :maestro-ios-driver:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt:45:63 Unchecked cast: Map<*, *>! to Map<String, Any>

> Task :maestro-ios-driver:compileJava NO-SOURCE
> Task :maestro-ios-driver:classes
> Task :maestro-ios-driver:jar
> Task :maestro-ios-driver:inspectClassesForKotlinIC
> Task :maestro-ios-driver:assemble
> Task :maestro-ios-driver:compileTestKotlin
> Task :maestro-ios-driver:compileTestJava NO-SOURCE
> Task :maestro-ios-driver:testClasses UP-TO-DATE
> Task :maestro-ios-driver:test
> Task :maestro-ios-driver:check
> Task :maestro-ios-driver:build

> Task :maestro-ios:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-ios/src/main/java/ios/simctl/SimctlIOSDevice.kt:92:58 Right operand of elvis operator (?:) is useless if it is null

> Task :maestro-ios:compileJava NO-SOURCE
> Task :maestro-ios:classes UP-TO-DATE
> Task :maestro-ios:jar
> Task :maestro-ios:inspectClassesForKotlinIC
> Task :maestro-client:extractIncludeProto
> Task :maestro-client:generateProto
> Task :maestro-ios:assemble
> Task :maestro-ios:compileTestKotlin NO-SOURCE
> Task :maestro-ios:compileTestJava NO-SOURCE
> Task :maestro-ios:testClasses UP-TO-DATE
> Task :maestro-ios:test NO-SOURCE
> Task :maestro-ios:check UP-TO-DATE
> Task :maestro-ios:build
> Task :maestro-client:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/Maestro.kt:561:13 Name shadowed: timeout
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/drivers/WebDriver.kt:178:57 Unchecked cast: Any? to Map<String, Any>
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/drivers/WebDriver.kt:187:58 Unchecked cast: Any? to List<Map<String, Any>>
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/drivers/WebDriver.kt:193:34 Unchecked cast: Any to Map<String, Any>
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/drivers/WebDriver.kt:288:15 Parameter 'start' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/drivers/WebDriver.kt:288:29 Parameter 'end' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:84:9 Unreachable code
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:103:21 Name shadowed: response
w: file:///Users/prasantabiswas/git/maestro/maestro-client/src/main/java/maestro/mockserver/MockInteractor.kt:109:9 Unreachable code

> Task :maestro-client:compileJava
> Task :maestro-client:classes
> Task :maestro-client:jar
> Task :maestro-client:inspectClassesForKotlinIC
> Task :maestro-client:assemble
> Task :maestro-client:extractIncludeTestProto
> Task :maestro-client:generateTestProto NO-SOURCE
> Task :maestro-client:compileTestKotlin
> Task :maestro-client:compileTestJava NO-SOURCE
> Task :maestro-client:testClasses

> Task :maestro-orchestra-models:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt:276:55 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt:326:55 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:32:60 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:37:66 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:72:34 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:77:37 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:112:9 'tapOnPoint: TapOnPointCommand?' is deprecated. Use tapOnPointV2Command
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:112:31 'tapOnPoint: TapOnPointCommand?' is deprecated. Use tapOnPointV2Command
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:117:9 'assertCommand: AssertCommand?' is deprecated. Use assertConditionCommand
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt:117:34 'assertCommand: AssertCommand?' is deprecated. Use assertConditionCommand
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroConfig.kt:44:25 Parameter 'jsEngine' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroConfig.kt:50:25 Parameter 'jsEngine' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/WorkspaceConfig.kt:10:16 'Local' is deprecated. Use ExecutionOrder instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/WorkspaceConfig.kt:15:23 Parameter 'key' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra-models/src/main/java/maestro/orchestra/WorkspaceConfig.kt:15:36 Parameter 'other' is never used

> Task :maestro-client:test
> Task :maestro-orchestra-models:compileJava NO-SOURCE
> Task :maestro-orchestra-models:classes UP-TO-DATE
> Task :maestro-orchestra-models:jar
> Task :maestro-orchestra-models:inspectClassesForKotlinIC
> Task :maestro-client:check
> Task :maestro-client:build
> Task :maestro-orchestra-models:assemble
> Task :maestro-orchestra-models:compileTestKotlin
> Task :maestro-orchestra-models:compileTestJava NO-SOURCE
> Task :maestro-orchestra-models:testClasses UP-TO-DATE
> Task :maestro-orchestra-models:test
> Task :maestro-orchestra-models:check
> Task :maestro-orchestra-models:build

> Task :maestro-orchestra:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:248:16 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:257:16 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:350:9 Unreachable code
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:763:40 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt:799:18 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead

> Task :maestro-orchestra:compileJava NO-SOURCE
> Task :maestro-orchestra:classes UP-TO-DATE
> Task :maestro-orchestra:jar
> Task :maestro-orchestra:inspectClassesForKotlinIC
> Task :maestro-orchestra:assemble
> Task :maestro-test:compileKotlin
> Task :maestro-test:compileJava NO-SOURCE
> Task :maestro-test:classes UP-TO-DATE
> Task :maestro-test:jar
> Task :maestro-test:inspectClassesForKotlinIC
> Task :maestro-test:assemble

> Task :maestro-studio:server:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-studio/server/src/main/java/maestro/studio/DeviceService.kt:96:17 'static(String, Route.() -> Unit): Route' is deprecated. Please use `staticFiles` or `staticResources` instead
w: file:///Users/prasantabiswas/git/maestro/maestro-studio/server/src/main/java/maestro/studio/DeviceService.kt:98:13 'files(String): Unit' is deprecated. Please use `staticFiles` instead

> Task :maestro-studio:server:compileJava NO-SOURCE
> Task :maestro-studio:server:classes
> Task :maestro-studio:server:jar
> Task :maestro-studio:server:inspectClassesForKotlinIC

> Task :maestro-orchestra:compileTestKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/test/java/maestro/orchestra/MaestroCommandSerializationTest.kt:57:13 'TapOnPointCommand' is deprecated. Use TapOnPointV2Command instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/test/java/maestro/orchestra/MaestroCommandSerializationTest.kt:214:13 'AssertCommand' is deprecated. Use AssertConditionCommand instead
w: file:///Users/prasantabiswas/git/maestro/maestro-orchestra/src/test/java/maestro/orchestra/workspace/WorkspaceExecutionPlannerErrorsTest.kt:42:14 Parameter 'testCaseName' is never used

> Task :maestro-orchestra:compileTestJava NO-SOURCE
> Task :maestro-orchestra:testClasses
> Task :maestro-test:compileTestKotlin
> Task :maestro-orchestra:test
> Task :maestro-orchestra:check
> Task :maestro-orchestra:build
> Task :maestro-test:compileTestJava NO-SOURCE
> Task :maestro-test:testClasses

> Task :maestro-cli:compileKotlin
w: file:///Users/prasantabiswas/git/maestro/maestro-cli/src/main/java/maestro/cli/api/ApiClient.kt:352:60 Unchecked cast: Any? to Map<String, Any>
w: file:///Users/prasantabiswas/git/maestro/maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:189:25 Destructured parameter 'shardIndex' is never used
w: file:///Users/prasantabiswas/git/maestro/maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt:333:47 Parameter 'index' is never used, could be renamed to _
w: file:///Users/prasantabiswas/git/maestro/maestro-cli/src/main/java/maestro/cli/report/HtmlTestSuiteReporter.kt:120:15 'script(String? = ..., String? = ..., String = ...): Unit' is deprecated. This tag doesn't support content or requires unsafe (try unsafe {})
w: file:///Users/prasantabiswas/git/maestro/maestro-cli/src/main/java/maestro/cli/runner/TestRunner.kt:100:29 Variable 'cachedAppState' is never used

> Task :maestro-test:test
> Task :maestro-cli:compileJava NO-SOURCE
> Task :maestro-cli:classes
> Task :maestro-cli:jar
> Task :maestro-cli:inspectClassesForKotlinIC
> Task :maestro-cli:startScripts
> Task :maestro-cli:distTar
> Task :maestro-cli:distZip
> Task :maestro-cli:shadowJar
> Task :maestro-cli:startShadowScripts
> Task :maestro-cli:shadowDistTar
> Task :maestro-cli:shadowDistZip
> Task :maestro-cli:assemble
> Task :maestro-test:check
> Task :maestro-test:build
> Task :maestro-studio:server:startScripts
> Task :maestro-studio:server:distTar
> Task :maestro-cli:compileTestKotlin
> Task :maestro-studio:server:distZip
> Task :maestro-cli:compileTestJava NO-SOURCE
> Task :maestro-cli:testClasses UP-TO-DATE
> Task :maestro-cli:test
> Task :maestro-cli:check
> Task :maestro-cli:build
> Task :maestro-studio:server:assemble
> Task :maestro-studio:server:compileTestKotlin NO-SOURCE
> Task :maestro-studio:server:compileTestJava NO-SOURCE
> Task :maestro-studio:server:testClasses UP-TO-DATE
> Task :maestro-studio:server:test NO-SOURCE
> Task :maestro-studio:server:check UP-TO-DATE
> Task :maestro-studio:server:build

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 2 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD SUCCESSFUL in 14m 12s
148 actionable tasks: 65 executed, 83 up-to-date
12:01:00 pm: Execution finished 'build'.

prasanta-biswas avatar Jun 21 '24 07:06 prasanta-biswas

@lucaswiechmann possible to merge this?

prasanta-biswas avatar Jun 24 '24 08:06 prasanta-biswas

Hey @prasanta-biswas This PR is breaking things internally. @bartekpacia and I is taking a close look on it this week!

lucaswiechmann avatar Jul 18 '24 12:07 lucaswiechmann

@lucaswiechmann any updates on this?

Alaksion avatar Jul 29 '24 19:07 Alaksion

Hey @Alaksion, sorry about the delay! I plan to get to it this week. Thanks for understanding.

bartekpacia avatar Jul 29 '24 21:07 bartekpacia

@bartekpacia any update here?

prasanta-biswas avatar Aug 02 '24 06:08 prasanta-biswas

Hey @prasanta-biswas, could you rebase/merge with master?

bartekpacia avatar Aug 06 '24 10:08 bartekpacia

@bartekpacia done

prasanta-biswas avatar Aug 06 '24 14:08 prasanta-biswas

@bartekpacia test cloud job failed due to incorrect command. could you please check the job configuration?

prasanta-biswas avatar Aug 06 '24 16:08 prasanta-biswas

Don't worry about it, it's because the secret is missing

bartekpacia avatar Aug 06 '24 16:08 bartekpacia

@bartekpacia can you please retry the job if the missing secret is added?

prasanta-biswas avatar Aug 07 '24 08:08 prasanta-biswas

Hey @prasanta-biswas, don't worry about the secret, it's not available to jobs running for PRs open-source contributors. We want to guard that secret:)

bartekpacia avatar Aug 08 '24 14:08 bartekpacia