pikabu icon indicating copy to clipboard operation
pikabu copied to clipboard

Multiple Pikabus should make multiple shades

Open kpeatt opened this issue 10 years ago • 4 comments

Right now, because shade is instantiated on the Pikabu container and not on the individual Pikabus, you can't have more than one shade. Which means the first shade you instantiate is the only shade you get. Should we allow for multiple shades for each Pikabu on the page? My thought is: yes.

kpeatt avatar Mar 18 '15 22:03 kpeatt

What’s the use case? The only thing I can think of is to add different styling or animation. That could be enabled with a single shade if that’s easier.

ry5n avatar Mar 19 '15 17:03 ry5n

@ry5n Currently, the way shade is built, its properties only get passed through on init. So if you want one Pikabu to have a different style of shade than the previous one, you're SOL. If you want it to cover something different or be somewhere else, you're SOL. I think our best bet is to have one per.

kpeatt avatar Mar 20 '15 14:03 kpeatt

@kpeatt Yup, makes sense.

ry5n avatar Mar 20 '15 14:03 ry5n

We should really fix this.

tedtate avatar Aug 19 '19 18:08 tedtate