Mohsen Esmailpour

Results 70 comments of Mohsen Esmailpour

Hey @danijel88 It's a good idea. To implement this functionality, hierarchical organization (or departments) should be introduced and users assigned to the organization tree. For example, a user with an...

@danijel88, Thanks for sharing codes!

I'm not sure if it going to happen because `HttpContext` in ASP.NET Core is not a singleton and for each request, a new instance of `HttpContext` will be populated and...

> It's the two concurrent `GetAsync`s of the HttpClient that cause the logger to be concurrently accessed and, through the enricher, the `HttpContext.Items` is concurrently accessed as well (because both...

Changing code at [line 53](https://github.com/mo-esmp/serilog-enrichers-clientinfo/blob/17a441e1dd1aa82b92b013e1fb75b98a25da6369/src/Serilog.Enrichers.ClientInfo/Enrichers/ClientIpEnricher.cs#L53) would fix the problem, however, any suggestion to do it in a more performant way? ```csharp lock(locker) { if (httpContext.Items[IpAddressItemKey] is LogEventProperty logEventProperty) return; var...

I think with the above code then installing this package is pointless.

I followed the Swashbuckle Swagger approach for authentication, simple and easy to implement. I don't think there is a problem with storing token in session storage, however, there is a...

This library supports cookie. If your authentication mechanism is based on the cookie and as long as you are logged in, for each request to get logs, the authentication cookie...

Thanks for the PR. Other data providers should be checked and need to find a way to add integration tests against databases to avoid manual testing every time.

Hey @followynne, Thanks again to double check, for the weekend I will have time to check the PR and sorry for delay.