even-better-ls icon indicating copy to clipboard operation
even-better-ls copied to clipboard

Add additional commands if install target is macOS (#18)

Open heyitsols opened this issue 7 years ago • 8 comments

Checks if the install target is macOS and changes behaviour based on that

heyitsols avatar Jun 28 '17 12:06 heyitsols

You should change

sudo mv ls_colors_generator.py /usr/bin/ls_colors_generator

to

sudo mv ls_colors_generator.py $install_location/ls_colors_generator

In MacOS even the root user doesn't have access to /usr/bin

Noammac avatar Jun 28 '17 17:06 Noammac

NOTE: this PR closes both #4 and #18, and is a more dynamic version of #13

Noammac avatar Jun 28 '17 18:06 Noammac

@Noammac good spot, I have just amended the install script in line with that

heyitsols avatar Jun 28 '17 19:06 heyitsols

Actually made this a little cleaner by removing each individual download method and replacing with either curl -o or wget -O depending on platform

heyitsols avatar Jun 29 '17 15:06 heyitsols

You (accidentally, I hope) deleted ls.c

Noammac avatar Jun 29 '17 17:06 Noammac

Not deleted, just empty. Not sure how it happened but I was testing the install script in that directory rather than a scratch directory. Can't reproduce it happening again though so maybe it's from cancelling the script halfway through.

Should all be back to normal now :)

heyitsols avatar Jun 29 '17 20:06 heyitsols

Is there any more progress on OS X support?

nicklanng avatar Jan 02 '18 08:01 nicklanng

@nicklanng looks like progress has stalled on this repo, feel free to clone my fork which has this fix in its master branch

https://github.com/muggahtee/even-better-ls

heyitsols avatar Jan 02 '18 16:01 heyitsols