even-better-ls icon indicating copy to clipboard operation
even-better-ls copied to clipboard

Mac os

Open Moonbeam4520 opened this issue 7 years ago • 3 comments

modified install.sh to make it work on macOS Sierra. tested with zsh on macOS 10.12.4 (16E195).

Moonbeam4520 avatar Jun 06 '17 12:06 Moonbeam4520

That branch gave me this output:

16 warnings generated.
  CCLD     dd
  CC       ls.o
  CC       ls-dir.o
  CCLD     dir
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [dir] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
mv: rename ls to /usr/bin/ls-i: No such file or directory
mv: rename dir to /usr/bin/dir-i: No such file or directory
mv: rename vdir to /usr/bin/vdir-i: No such file or directory

nicklanng avatar Jun 06 '17 12:06 nicklanng

Removing the shebang and encoding notation from ls_colors_generator will not only make it not execute (since the shebang is used by Linux to determine what program to use to execute the file), but supposing it will be executed by python, it won't be python 2 compatible!. Also, the addition to the ./configure line will make it break on some machines.

I propose that the install script will be smarter and check for OS before executing the commands, thus allowing for a one-file-fits-all solution.

Noammac avatar Jun 06 '17 13:06 Noammac

oups, that was unwanted, I deleted the file by mistake and copy pasted it, so it was a mistake. I'll investigate later on the ld error, thanks :)

Moonbeam4520 avatar Jun 06 '17 13:06 Moonbeam4520