composer-custom-directory-installer icon indicating copy to clipboard operation
composer-custom-directory-installer copied to clipboard

Why it doesn't work for "tinymce"?

Open ivangusev opened this issue 4 years ago • 10 comments

Installing "tinymce/tinymce" it simply ignores "extra" section.

ivangusev avatar Oct 16 '19 09:10 ivangusev

hello @ivangusev

Basically, my plugin is sticking to the default composer package types which are listed here https://getcomposer.org/doc/04-schema.md#type except for the type project but the tinymc has set the type to be component

but may be i can look into this later, but i just wanted to explain the issue briefly

mnsami avatar Oct 17 '19 09:10 mnsami

hi, @mnsami

Thanks for reply! I really need to install tinymce in different vendor folder, because it is supposed to be requested from public. Would be awesome if i can do it with your plugin. Or may be you can suggest me other solution/plugin?

ivangusev avatar Oct 17 '19 09:10 ivangusev

@ivangusev I'll check and get back to you :)

mnsami avatar Oct 17 '19 12:10 mnsami

hello @ivangusev can you try to require this version of my plugin composer require mnsami/composer-custom-directory-installer:dev-allow-custom-packages-types

and see if tinymce works well afterwards

Let me know of the results

mnsami avatar Oct 21 '19 20:10 mnsami

hi, @mnsami

It works like a charm! Thanks a lot, great work!

ivangusev avatar Oct 22 '19 10:10 ivangusev

i think this library will work better and server your purpose better than this https://packagist.org/packages/robloach/component-installer

it is more focused on js components

I would recommend checking it out @ivangusev

mnsami avatar Oct 22 '19 14:10 mnsami

@ivangusev can you check the package I mentioned, it makes more sense to use the component-install package rather than mine, it means the more correct way to go, but I want your validation of course :)

And I want to drop this pending branch.

Can you please get back to me.

mnsami avatar Nov 06 '19 13:11 mnsami

@mnsami i just remember before i found your package i tried the one you mentioned. It was some issue there. I can try again, in next few days when i get a chance. Okay?

ivangusev avatar Nov 06 '19 13:11 ivangusev

Hi @mnsami, component-install package has been deprecated. Anyway i tried and it works but it installs "require.js" thing which i don't want. Do you know how to disable this "require.js" install? I also tried oomphinc/composer-installers-extender, but it doesn't use an installer-paths whatever i write in "extra" section.

ivangusev avatar Nov 08 '19 08:11 ivangusev

Hi @mnsami , feature from allow-custom-packages-types branch works perfectly. Please, can you release new version with with feature? It will help me a lot, because lot of javascript packages use type component. Thanks.

liborm85 avatar Nov 18 '19 15:11 liborm85