scikit-tensor icon indicating copy to clipboard operation
scikit-tensor copied to clipboard

Implementation of CP-APR algorithm

Open theosotr opened this issue 9 years ago • 4 comments

CP-APR algorithm https://arxiv.org/pdf/1112.2414.pdf

The results of this implementation were tested against of that of MATLAB tensor toolbox, using the method described here. https://pdfs.semanticscholar.org/71b5/d7ad21cf479c0816b9df00b19df87f8787a1.pdf

theosotr avatar Nov 25 '16 22:11 theosotr

Looks good - thanks!

brianholland avatar Nov 26 '16 00:11 brianholland

Thanks also @hskarpetis for its valuable contributions.

theosotr avatar Nov 26 '16 15:11 theosotr

Thanks for the contribution!

It would be nice to have a small test case to check for correctness of the factorization. For instance, we can check the factors for a tensor where we know the correct factorization via numpy.allclose()

We can load matlab files via scipy.io. So checking against matlab results would work.

mnick avatar Nov 26 '16 16:11 mnick

Will do - I'll try a few fabricated examples of various ranks and tensor orders, likely before Monday. I'm also curious to see Marble ( http://ideal.ece.utexas.edu/pubs/pdf/2014/Marble-kdd14.pdf) because I'm not grokking why it isn't the same as adding one more rank.

On Sat, Nov 26, 2016 at 11:00 AM, Maximilian Nickel < [email protected]> wrote:

Thanks for the contribution!

It would be nice to have a small test case to check for correctness of the factorization. For instance, we can check the factors for a tensor where we know the correct factorization via numpy.allclose()

We can load matlab files via scipy.io. So checking against matlab results would work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mnick/scikit-tensor/pull/27#issuecomment-263070845, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAFnh5q21J8CoTqx2xQfDl1y1eWgTtiks5rCFeLgaJpZM4K8vLn .

brianholland avatar Nov 26 '16 16:11 brianholland