manifest icon indicating copy to clipboard operation
manifest copied to clipboard

test(e2e): add missing webhook tests

Open sahithvibudhi opened this issue 6 months ago • 5 comments

Description

Add missing webhook e2e tests

Related Issues

https://github.com/mnfst/manifest/issues/274

How can it be tested?

npm run test

Check list before submitting

  • [x ] This PR is wrote in a clear language and correctly labeled
  • [ x] I created the related changeset for my changes with npx changeset
  • [x ] I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • [ x] I wrote the relative tests
  • [ x] I created a PR for the documentation if necessary and attached the link to this PR

sahithvibudhi avatar Jun 22 '25 22:06 sahithvibudhi

Bundle Report

Bundle size has no change :white_check_mark:

codecov[bot] avatar Jun 23 '25 09:06 codecov[bot]

@brunobuddy can you review this when you get a chance?

sahithvibudhi avatar Jun 24 '25 01:06 sahithvibudhi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.44%. Comparing base (902c104) to head (184bef4). Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          58       58           
  Lines        1668     1668           
  Branches      385      376    -9     
=======================================
  Hits         1492     1492           
- Misses        155      170   +15     
+ Partials       21        6   -15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 24 '25 07:06 codecov[bot]

Since this change doesn't affect the published package, I’ve added an empty changeset to comply with contribution guidelines.

sahithvibudhi avatar Jun 24 '25 20:06 sahithvibudhi

just circling back on this PR! curious if there’s been any internal discussion or leaning on whether it’s a candidate for merge? Happy to make changes if needed.

sahithvibudhi avatar Jul 18 '25 20:07 sahithvibudhi