manifest icon indicating copy to clipboard operation
manifest copied to clipboard
Published 3 weeks ago • verified publisher icon mnfst

Update Twitter Logo to New "X" Branding

Open Piyush-Goenka opened this issue 1 year ago • 3 comments

Issue: Update Twitter Logo to New "X" Logo

Description

While scrolling down the page, the Twitter logo displayed is still the older version. We need to update it to the new logo, which is now referred to as "X".

Steps to Reproduce

  1. Navigate to the https://manifest.build
  2. Scroll down the page.
  3. Observe the Twitter logo.

Expected Behavior

The page should display the new "X" logo instead of the older Twitter logo.

Current Behavior

The old Twitter logo is still visible when scrolling down.

Screenshot

Screenshot 2024-09-28 at 12 56 52 AM

Suggested Solution

Replace the existing Twitter logo with the new "X" logo in the relevant files.

Thank you!

Piyush-Goenka avatar Sep 27 '24 19:09 Piyush-Goenka

Welcome to Manifest, thank you for adding your first issue !

github-actions[bot] avatar Sep 27 '24 19:09 github-actions[bot]

@SebConejo I would like to work on this issue.

Piyush-Goenka avatar Sep 27 '24 19:09 Piyush-Goenka

@Piyush-Goenka go ahead, the concerned repo is https://github.com/mnfst/website

You can follow the same contributing rules as in this repo !

brunobuddy avatar Sep 30 '24 07:09 brunobuddy

If this issue is still open, can I work on it? @brunobuddy @SebConejo

nitesh2920 avatar Oct 05 '24 13:10 nitesh2920

@brunobuddy I am unable to solve this issue please assign this issue to someone else .

Piyush-Goenka avatar Oct 07 '24 17:10 Piyush-Goenka

@nitesh2920 we use lineicon. This font doesn't contain the x icon for now. Maybe we could just use an svg icon to display this one instead of calling another whole font-icon.

SebConejo avatar Oct 08 '24 07:10 SebConejo

@SebConejo yeah I just wanted to ask that question.

nitesh2920 avatar Oct 08 '24 08:10 nitesh2920

@SebConejo I have one question I have to raise a PR in https://github.com/mnfst/website this repo instead of this as it is for backend only.

nitesh2920 avatar Oct 08 '24 08:10 nitesh2920

@nitesh2920 yes the repo is https://github.com/mnfst/website

brunobuddy avatar Oct 08 '24 13:10 brunobuddy

@brunobuddy so I have to first create a issue there then raise a PR for that issue.

nitesh2920 avatar Oct 08 '24 22:10 nitesh2920

@brunobuddy @SebConejo raised the PR please check https://github.com/mnfst/website/pull/29#issue-2576495831

nitesh2920 avatar Oct 09 '24 17:10 nitesh2920

Hello @nitesh2920 sorry this is not applicable anymore as we are not displaying personal accounts on the website

brunobuddy avatar Dec 17 '24 07:12 brunobuddy