manifest icon indicating copy to clipboard operation
manifest copied to clipboard

style: Update the look and feel of the `responses` title on the API docs to make it easier to read

Open SebConejo opened this issue 1 year ago • 10 comments

The structure of the API documentation is difficult to follow.

When testing an endpoint, the API documentation first displays the test response, followed by a list of possible responses. Both sections have titles, but these titles are not very prominent. They are written in small text with minimal whitespace above them, making them hard to notice. The separation between these two sections could be improved.


My suggestions:

  • [ ] Increase the white space above the title.
  • [ ] If it's not enough visible, try to use a different color, or add a separator line, or even try adding emojis.

Remarks

  • It looks unnecessary to increase the font size as the parent title is small too.

Capture d’écran 2024-08-30 à 10 45 51

Capture d’écran 2024-09-23 à 14 34 59

SebConejo avatar Aug 01 '24 12:08 SebConejo

@SebConejo Hi SebConejo I am happy to contribute to this issue and solve it, could i

LoayTarek5 avatar Sep 23 '24 12:09 LoayTarek5

Hi @LoayTarek5. I assigned you to the issue 👍

SebConejo avatar Sep 23 '24 14:09 SebConejo

@SebConejo should I solve it and merge at beginning Hacktoberfest or is it ok to pull/merge now

LoayTarek5 avatar Sep 23 '24 14:09 LoayTarek5

@LoayTarek5 If the work is ready and doesn't need to be tied to Hacktoberfest, you can do it now. We will review it this week. If your goal is to "earn points" during Hacktoberfest, you have to wait for October 1st before making a PR.

SebConejo avatar Sep 23 '24 14:09 SebConejo

@SebConejo Oh, I am sorry. By mistake I removed myself, could you assign it to me again. Anyway, I will work on this issue now.

LoayTarek5 avatar Sep 23 '24 14:09 LoayTarek5

@SebConejo Sorry, I couldn't find the file I need to edit to fix the style. Can you please tell me which file to edit?

LoayTarek5 avatar Sep 24 '24 07:09 LoayTarek5

@SebConejo Sorry, I couldn't find the file I need to edit to fix the style. Can you please tell me which file to edit?

@LoayTarek5 The file is this one: packages\core\manifest\src\main.ts

We use swaggerUI for now. The css is writtten directly in this typescript file.

SebConejo avatar Sep 25 '24 07:09 SebConejo

image

image @SebConejo Is it good?

LoayTarek5 avatar Sep 25 '24 15:09 LoayTarek5

@LoayTarek5 Thank you for your proposal. Here are my comments:

  • Could you use this blue instead: #2430F0 ? Or this one if you think it's easier to read: #1eb1e8. Those blues are in the toolkit.
  • The change should only be made to h4. Not on response headers, response bodies. You see what I mean? 370774766-41f18b9e-7282-455a-b107-3f0d2a9e3b3a

SebConejo avatar Sep 26 '24 07:09 SebConejo

@SebConejo ok i will use #1eb1e8 i think it is better Is this how it should look? image

or you want only edit on this : image

LoayTarek5 avatar Sep 26 '24 08:09 LoayTarek5