mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

Enhancements to modified Beer Lambert Law

Open rob-luke opened this issue 4 years ago • 2 comments

Describe the new feature or enhancement

In the discussion at https://github.com/mne-tools/mne-python/pull/8711 the following enhancements for the BLL were mentioned. I am listing them here so these suggestions don't get lost.

  • [ ] Add support for alternative extinction coefficients.
  • [ ] Refactor code to have private function where source-detector distance can be specified.
  • [ ] Add some references to literature.
  • [ ] Add age dependent partial path length factor (reference)

Additional comments

The code works fine as is. This is just optional improvements for when anyone has time. Please list additional feature requests below too.

rob-luke avatar Jan 12 '21 21:01 rob-luke

Hi! I would like to suggest a new feature to this function. It should be possible to use a ppf per wavelength, similar to what is possible in Homer3 where ppf is a vector of factors per wavelength.

see https://github.com/BUNPC/Homer3/blob/master/FuncRegistry/UserFunctions/hmrR_OD2Conc.m

scholzri avatar Feb 06 '24 21:02 scholzri

@AdmerStroh would you be up for adding support for this to MNE-Python?

larsoner avatar Feb 08 '24 17:02 larsoner