mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

ylims broken for evoked.plot(gfp='only')

Open jona-sassenhagen opened this issue 7 months ago • 3 comments

Description of the problem

With evoked.plot(gfp='only'), the ylim upper bound is not set properly, but to 1.

Image

Steps to reproduce

Run this tutorial:

https://mne.tools/stable/auto_tutorials/evoked/30_eeg_erp.html#sphx-glr-auto-tutorials-evoked-30-eeg-erp-py

`l_aud.plot(gfp="only")`

Link to data

No response

Expected results

Something like

Image

Actual results

Additional information

jona-sassenhagen avatar Jun 02 '25 11:06 jona-sassenhagen

argh, regressions like this make me seriously consider image-diff regression tests for our tutorials. It's a big can of worms but Matplotlib does it, maybe we can borrow some best practices from them.

drammock avatar Jun 02 '25 13:06 drammock

@drammock did you see https://github.com/mne-tools/mne-python/pull/13266 ? :)

jona-sassenhagen avatar Jun 02 '25 14:06 jona-sassenhagen

@drammock did you see #13266 ? :)

indeed I did

drammock avatar Jun 02 '25 15:06 drammock