mne-python
mne-python copied to clipboard
Support preload=False for the new EEGLAB single .set format
Reference issue (if any)
What does this implement/fix?
EEGLAB introduced a new mechanism that allows reading only metadata from a single .set file that has both data and metadata. Thus raw data no longer needed to be stored in a separate .fdt file. Adding this feature to MNE. This implementation uses scipy's loadmat and whosmat functions.
Additional information
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴
Hey @larsoner and @cbrnr
Eric, thank you very much for the first review.
One question that I am having, and it is something that I spend one hour doing git blame and looking old PRs, can I swap the default option for using scipy loadmat here?
Rely primarily on scipy to read the .set and if fail pymatreader.
The pr is still WIP, btw.
hey @larsoner, I think I will need to include a new file in the test that shows the separation of the .set, but I am still working on
It is working with scipy locally!!! happyyy.... not super super well with py mat reader, I am working on
Hey @larsoner, @cbrnr, and @sappelhoff, I think it's done for the first iteration! preload=False for ".set" files 😄 Can you please review?
More modifications are needed, which I only noticed in the exportation test in the CI.
Now it is all good on my side @larsoner, @cbrnr, and @sappelhoff.
all good here @larsoner
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪
Thanks @bruAristimunha!