mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

Support preload=False for the new EEGLAB single .set format

Open dungscout96 opened this issue 10 months ago • 1 comments

Reference issue (if any)

What does this implement/fix?

EEGLAB introduced a new mechanism that allows reading only metadata from a single .set file that has both data and metadata. Thus raw data no longer needed to be stored in a separate .fdt file. Adding this feature to MNE. This implementation uses scipy's loadmat and whosmat functions.

Additional information

dungscout96 avatar Feb 03 '25 14:02 dungscout96

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

welcome[bot] avatar Feb 03 '25 14:02 welcome[bot]

Hey @larsoner and @cbrnr

Eric, thank you very much for the first review.

One question that I am having, and it is something that I spend one hour doing git blame and looking old PRs, can I swap the default option for using scipy loadmat here?

Rely primarily on scipy to read the .set and if fail pymatreader.

The pr is still WIP, btw.

bruAristimunha avatar Oct 16 '25 00:10 bruAristimunha

hey @larsoner, I think I will need to include a new file in the test that shows the separation of the .set, but I am still working on

bruAristimunha avatar Oct 17 '25 14:10 bruAristimunha

It is working with scipy locally!!! happyyy.... not super super well with py mat reader, I am working on

bruAristimunha avatar Oct 17 '25 16:10 bruAristimunha

Hey @larsoner, @cbrnr, and @sappelhoff, I think it's done for the first iteration! preload=False for ".set" files 😄 Can you please review?

bruAristimunha avatar Oct 17 '25 16:10 bruAristimunha

More modifications are needed, which I only noticed in the exportation test in the CI.

bruAristimunha avatar Oct 17 '25 19:10 bruAristimunha

Now it is all good on my side @larsoner, @cbrnr, and @sappelhoff.

bruAristimunha avatar Oct 17 '25 21:10 bruAristimunha

all good here @larsoner

bruAristimunha avatar Oct 20 '25 16:10 bruAristimunha

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

welcome[bot] avatar Oct 21 '25 14:10 welcome[bot]

Thanks @bruAristimunha!

cbrnr avatar Oct 21 '25 14:10 cbrnr