mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

ENH: find_blinks (pupil)

Open sappelhoff opened this issue 1 year ago • 9 comments

  • closes https://github.com/mne-tools/mne-python/issues/12808

This PR is currently a draft to discuss an API for a potential find_blinks function that works on eye-tracking data.

Comments welcome -- I would also be happy for pushes to this branch, but if nobody will, then I may eventually get to implementing this, too.

to do

  • [ ] consensus about API
  • [ ] add function proper
  • [ ] add test
  • [ ] show use in example

sappelhoff avatar Nov 05 '24 16:11 sappelhoff

@larsoner @britta-wstnr @mscheltienne @drammock @AlexLepauvre @qian-chu @scott-huberty

what do you think of this suggested API?

sappelhoff avatar Nov 06 '24 10:11 sappelhoff

Hello everyone, apologies for the radio silence. Myself and @qian-chu got a bit sidetracked over the past few months. I will get back to it next week and follow the recommendation laid out above to bring this PR further :)

AlexLepauvre avatar Nov 08 '24 08:11 AlexLepauvre

Thanks for taking the initiative and looping me in! I'm just back from a vacation and also simultaneously developing a package myself so sorry for the limited attention on this implementation. I will try to keep up with the latest development here :)

qian-chu avatar Nov 26 '24 16:11 qian-chu

Since blink detection is usually based on pupil data, do you also think it makes more sense to put find_blinks() under _pupillometry.py?

qian-chu avatar Nov 26 '24 16:11 qian-chu

Since blink detection is usually based on pupil data, do you also think it makes more sense to put find_blinks() under _pupillometry.py?

would be fine by me, too.

sappelhoff avatar Nov 26 '24 18:11 sappelhoff