mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

BUG: viz plot window's 'title' argument showed no effect.

Open shristibaral opened this issue 1 year ago • 3 comments

viz plot window's 'title' argument showed no effect. Fix: if title is given, title along with subject's name will be displayed on plot window title, if title is none then subject name will be displayed as title.

Reference issue

Example: Fixes #1234.

What does this implement/fix?

Explain your changes.

Additional information

Any additional information you think is important.

shristibaral avatar Sep 05 '24 10:09 shristibaral

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

welcome[bot] avatar Sep 05 '24 10:09 welcome[bot]

Looks reasonable @shristibaral ! Can you add a doc/changes/devel/12828.bugfix.rst with something like:

Fixed behavior of :func:`mne.viz.plot_source_estimates` where the ``title`` was not displayed properly, by :newcontrib:`Shristi Baral`.

and then add your name to doc/changes/names.inc?

larsoner avatar Sep 06 '24 13:09 larsoner

I have added updated docs file

shristibaral avatar Sep 06 '24 13:09 shristibaral

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

welcome[bot] avatar Jan 10 '25 17:01 welcome[bot]