mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

code credit dedup

Open drammock opened this issue 1 year ago • 2 comments

Some possible deduplications:

  • Jean-Remi KING and Jean-Remi King are separate entries
  • Valerii and Valerii Chirkov
  • PAB and Pierre-Antoine Bannier
  • Jordan Drew and Drew, J.
  • Deleted user still shows up (even though it's trying to be excluded in update_credit_rst.py)

Something I think we discussed before, but I can't recall what was decided:

  • there are some folks who I'm pretty sure are in our .mailmap but their usernames aren't getting parsed out here (TzionaN, Sena, and Martin are a few examples I noticed; probably there are more). Did we decide not to use .mailmap for some reason? Or is it a bug that these users aren't getting the preferred name displayed?

drammock avatar Aug 27 '24 18:08 drammock

Regarding names when things were ambiguous I think I tried to side with names.inc. There are three potential sources of truth: that, GitHub profile, and .mailmap. I figure mailmap is most remote from the users (maintained by us) so we should probably try to make it match the other two (esp. names.inc since users typically had to make a conscious choice at time of contribution for that) but not 100% sure.

larsoner avatar Aug 28 '24 00:08 larsoner

I should be able to look into this tomorrow

larsoner avatar Aug 28 '24 04:08 larsoner