mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

Published 20 hours ago • verified publisher icon mne-tools

MAINT: Remove code using vulture confidence 60

Open larsoner opened this issue 1 year ago • 2 comments

Turns out we had a bunch of dead code. We also had a bunch of unused global vars in our test files which this caught!

This also makes me think that we should maybe add a test that checks the inventory of the testing dataset to make sure all files are used. Given the removals here it's possible that some no longer are, and it's either a bug and we should add them back somehow or we should remove them from the testing dataset...

larsoner avatar Apr 24 '24 15:04 larsoner

Wow this is massive

hoechenberger avatar Apr 24 '24 15:04 hoechenberger

@drammock this one should be good to go now!

larsoner avatar May 17 '24 13:05 larsoner

Some of it seems useful enough that I'm wondering if it should either get promoted to public API, or spun off into a utils-like section of mne-incubator

Perhaps. I'm happy to leave it out for now and see if people need it and assume YAGNI until then. Plus we don't know the extent to which those snippets of code still work with our codebase at this point since they haven't been tested. It's easy enough to find in the history especially knowing the lines were removed in this vulture PR, though, if we do want them.

larsoner avatar May 21 '24 17:05 larsoner