mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

Published 20 hours ago • verified publisher icon mne-tools

MAINT: Add steering committee members to CODEOWNERS

Open larsoner opened this issue 2 years ago • 11 comments

Hey @mne-tools/mne-python-steering-committee, could each of you please take a moment to open a PR to add yourself to CODEOWNERS in this repo? We would like to start using this as a way to triage issues, PR reviews, and forum posts to people with relevant domain expertise.

Feel free to use as fine-grained or coarse file patterns as you want following the gitignore syntax (see also cheatsheet). To make an example, I've opened a PR on behalf of @rob-luke in https://github.com/mne-tools/mne-python/pull/11972. (And @sappelhoff if you're happy with your current set of files, no need to update anything!)

Progress:

  • [x] agramfort
  • [x] wmvanvliet
  • [x] rob-luke
  • [x] drammock
  • [x] dengemann
  • [x] hoechenberger
  • [x] larsoner
  • [x] adam2392
  • [x] cbrnr
  • [x] bloyl
  • [ ] mmagnuski
  • [x] sappelhoff
  • [x] alexrockhill
  • [x] jasmainak
  • [x] GuillaumeFavelier
  • [x] britta-wstnr
  • [x] mscheltienne

larsoner avatar Sep 08 '23 20:09 larsoner

Ping @dengemann @mmagnuski @jasmainak do you want to be added somewhere?

larsoner avatar Oct 02 '23 09:10 larsoner

please add me here:

https://github.com/mne-tools/mne-python/blob/8051f6ddf68a797ec0c9e1801aea3c73808bba03/.github/CODEOWNERS#L84

I'll make a PR to add myself if something else crops up in the future

jasmainak avatar Oct 03 '23 02:10 jasmainak

please add me here:

https://github.com/mne-tools/mne-python/blob/8051f6ddf68a797ec0c9e1801aea3c73808bba03/.github/CODEOWNERS#L84

I'll make a PR to add myself if something else crops up in the future

Please do this PR yourself. Can be your first contribution to this week's sprint :)

drammock avatar Oct 03 '23 11:10 drammock

I didn't know that adding myself to this file automatically triggers review requests. I thought we'd be using it a bit less formally, e.g. to look up who could help with certain parts of the code. So my questions is: is this behavior intentional? If so, I think I'll remove myself from several topics.

cbrnr avatar Oct 03 '23 14:10 cbrnr

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

drammock avatar Oct 03 '23 15:10 drammock

Sorry for missing this, I'll take a look and add myself here and there (separate PR then).

mmagnuski avatar Oct 03 '23 22:10 mmagnuski

Still some left to add, reopening

larsoner avatar Oct 06 '23 12:10 larsoner

okay I went ahead and added myself to codeowners here

practically speaking though, I watch all the discussions on mne-python and pitch in when necessary ... everything goes through a filter in the mailbox and is checked periodically. I don't think it's easy to create separate filters for codeowner-triggered notifications vs rest of github.

jasmainak avatar Oct 06 '23 14:10 jasmainak

@jasmainak be aware that whenever a PR touches one of the parts of the project that you signed up as a code owner for, a review request will be triggered, as @cbrnr mentioned above This might totally spam your GH Notification center

hoechenberger avatar Oct 06 '23 14:10 hoechenberger

cc @mmagnuski @GuillaumeFavelier @bloyl friendly ping --> you're still missing from the file :-)

sappelhoff avatar Oct 24 '23 18:10 sappelhoff

@mmagnuski happy new year! Do you have a minute to add yourself to CODEOWNERS?

larsoner avatar Jan 10 '24 15:01 larsoner

Closing since this is complete enough I think

larsoner avatar Jul 15 '24 19:07 larsoner