mne-cpp icon indicating copy to clipboard operation
mne-cpp copied to clipboard

[Fix] Fix leak in test_coregistration and attends various warnings

Open juangpc opened this issue 4 years ago • 2 comments

juangpc avatar Oct 06 '21 13:10 juangpc

Codecov Report

Merging #849 (d118b7c) into main (fe015fd) will decrease coverage by 0.01%. The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   30.10%   30.08%   -0.02%     
==========================================
  Files         452      452              
  Lines       39254    39253       -1     
==========================================
- Hits        11816    11809       -7     
- Misses      27438    27444       +6     
Impacted Files Coverage Δ
libraries/disp3D/engine/view/view3D.cpp 0.42% <ø> (+<0.01%) :arrow_up:
libraries/mne/mne.cpp 1.42% <ø> (ø)
libraries/mne/mne_forwardsolution.cpp 20.70% <0.00%> (-0.14%) :arrow_down:
libraries/mne/mne_forwardsolution.h 3.22% <ø> (-8.54%) :arrow_down:
libraries/rtprocessing/icp.cpp 82.02% <ø> (ø)
testframes/test_filtering/test_filtering.cpp 100.00% <ø> (ø)
testframes/test_hpiFit/test_hpiFit.cpp 97.93% <ø> (ø)
...y_surface_set/test_mne_msh_display_surface_set.cpp 100.00% <ø> (ø)
libraries/inverse/hpiFit/hpifit.cpp 82.25% <50.00%> (-0.23%) :arrow_down:
...frames/test_coregistration/test_coregistration.cpp 94.54% <100.00%> (-0.10%) :arrow_down:
... and 4 more

codecov-commenter avatar Oct 06 '21 13:10 codecov-commenter

@LorenzE Please review this whenever you can.

juangpc avatar Nov 03 '21 13:11 juangpc