mne-cpp icon indicating copy to clipboard operation
mne-cpp copied to clipboard

[ENH] MNEScan FTBuffer plugin - Channel names compatibility

Open juangpc opened this issue 4 years ago • 5 comments

juangpc avatar Sep 22 '21 18:09 juangpc

Ready for review. 😟

juangpc avatar Sep 22 '21 18:09 juangpc

Codecov Report

Merging #840 (5d6a36f) into main (dbd57f7) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   21.80%   21.78%   -0.03%     
==========================================
  Files         451      451              
  Lines       39087    39077      -10     
==========================================
- Hits         8522     8512      -10     
  Misses      30565    30565              
Impacted Files Coverage Δ
libraries/fiff/c/fiff_coord_trans_old.cpp 25.74% <ø> (ø)
libraries/fiff/fiff_id.cpp 80.00% <ø> (-2.82%) :arrow_down:
libraries/fiff/fiff_ch_info.cpp 100.00% <100.00%> (ø)

codecov-commenter avatar Sep 22 '21 18:09 codecov-commenter

I'm not sure what happened but there are a bunch of old commits added again in this pr

gabrielbmotta avatar Sep 29 '21 15:09 gabrielbmotta

Should be fixed now.

juangpc avatar Sep 29 '21 16:09 juangpc

@LorenzE @gabrielbmotta Please review this when you can.

juangpc avatar Nov 03 '21 13:11 juangpc