mne-bids-pipeline icon indicating copy to clipboard operation
mne-bids-pipeline copied to clipboard

ENH: Streamline ICA reporting

Open larsoner opened this issue 1 year ago • 8 comments

Before merging …

  • [x] Changelog has been updated (docs/source/changes.md)
  1. Moved all ICA reports to the main report:

    image

  2. Added docs suggesting manual intervention is required (maybe it should be suggested instead?) when using ICA to take care of the doc part of #881

  3. Add just one subject's data for ERP_CORE (plus the average) to the website to cut size down.

  4. Add script to remove examples from old versions so we don't have to remove their docs anymore (they go down to like 6MB or something!).

Closes #880

larsoner avatar Mar 20 '24 17:03 larsoner

@SophieHerbst can you look to see if the unified report titles and contents seem reasonable to you? Here is an example

https://output.circle-artifacts.com/output/job/3ed5bcd9-e31f-48c1-96c5-b582bd7bccfc/artifacts/0/site/examples/ERP_CORE/sub-015_ses-N170_task-N170_report.html#ICA__epochs_for_fitting

larsoner avatar Mar 22 '24 13:03 larsoner

@larsoner the report looks good to me! Do I understand correctly that there is only one single report now?

SophieHerbst avatar Mar 22 '24 14:03 SophieHerbst

Yep!

larsoner avatar Mar 22 '24 14:03 larsoner

Is this good to go? are you waiting for my review?

hoechenberger avatar Mar 27 '24 12:03 hoechenberger

Yeah this one is ready to go!

larsoner avatar Mar 27 '24 12:03 larsoner

If it's not super urgent, please allow me to review first before merging

I won't have time before later tonight or maybe even tomorrow, though

hoechenberger avatar Mar 27 '24 13:03 hoechenberger

@hoechenberger just a friendly reminder about this one when you get a chance!

larsoner avatar Apr 01 '24 14:04 larsoner

I won't have time to review it before the end of this week. If this is rather urgent, go ahead and merge and we'll do a follow-up PR if need be

hoechenberger avatar Apr 02 '24 08:04 hoechenberger

I'll fix the conflict here and merge, happy to do a follow-up PR if needed though @hoechenberger !

larsoner avatar Apr 16 '24 17:04 larsoner

ok with me, sorry for the delay here

hoechenberger avatar Apr 16 '24 17:04 hoechenberger

Added a workaround for https://github.com/joblib/joblib/issues/1572

larsoner avatar Apr 16 '24 19:04 larsoner