mne-bids-pipeline icon indicating copy to clipboard operation
mne-bids-pipeline copied to clipboard

Bug when running the make_forward script on rest session

Open apmellot opened this issue 3 years ago • 2 comments

The issue comes from the fact that info is read from evoked file in this script ( info = mne.io.read_info(fname_evoked)) but no evoked files are generated for rest session. @dengemann @agramfort @hoechenberger

apmellot avatar Aug 11 '21 08:08 apmellot

We could read it from Raw instead, I suppose?

hoechenberger avatar Aug 13 '21 18:08 hoechenberger

Yes. Caution: I suppose you took it from evoked because channels are picked at that point. We may need to think about preserving / translating that logic.

On Fri 13 Aug 2021 at 20:25, Richard Höchenberger @.***> wrote:

We could read it from Raw instead, I suppose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-bids-pipeline/issues/443#issuecomment-898643333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOR7CRWLJSB6Q2MPJJQAN3T4VPSBANCNFSM5B55YARQ .

dengemann avatar Aug 13 '21 18:08 dengemann

I think this was fixed at some point

https://github.com/mne-tools/mne-bids-pipeline/blob/1cddb952b217ad2d1c8451823842faceeb3afd71/mne_bids_pipeline/scripts/source/_04_make_forward.py#L99

I'm not worried about the channel picking because it's fine for forward to have more channels than evoked, channels should be picked properly automatically when computing the inverse operator for example

larsoner avatar Nov 08 '22 21:11 larsoner