mne-bids-pipeline icon indicating copy to clipboard operation
mne-bids-pipeline copied to clipboard

Explicate to which processing steps each config parameter applies, and whether params are optional or required

Open guiomar opened this issue 3 years ago • 12 comments

Hi!

Would you think it would be a good idea to have some information about the specific config parameters needed for each step (preprocessing/sensor/source)?

guiomar avatar May 18 '21 16:05 guiomar

My apologies if this doesn't make sense. I'm trying to figure out which parameters are strictly necessary for each of the steps

guiomar avatar May 18 '21 16:05 guiomar

This parameter: "interpolate_bads_grand_average" doesn't show on the website

guiomar avatar May 18 '21 16:05 guiomar

I would suggest you do a pair programming session with @hoechenberger so you feel

comfortable contributing fixes ot the pipeline documentation and code. That would be very helpful.

agramfort avatar May 18 '21 17:05 agramfort

That would be fantastic!

guiomar avatar May 18 '21 17:05 guiomar

I'll try to differentiate for each of the parameters:

  1. which steps are they being used in: preprocesing, sensor, source
  2. are they REQUIRED, RECOMMENDED or OPTIONAL (similar to what we have in BIDS)

That way we could have a better idea of which parameters we really need to set in the configuration file

guiomar avatar May 26 '21 17:05 guiomar

2. are they REQUIRED, RECOMMENDED or OPTIONAL (similar to what we have in BIDS)

This is a great idea. We should think about how to point this out in the documentation. We might want to create small macros (which you could use by simply typing {{ required }} or similar) to add certain markup elements.

hoechenberger avatar May 26 '21 17:05 hoechenberger

RECOMMENDED

I don't think we should have this one, though – seems more opinionated than the pipeline already is LOL

hoechenberger avatar May 26 '21 17:05 hoechenberger

Ok! Then we'll go with required and optional :)

guiomar avatar May 26 '21 18:05 guiomar

It was just a thought, I'm totally willing to discuss this :)

@SophieHerbst @agramfort @crsegerie WDYT? Relevant discussion starts here: https://github.com/mne-tools/mne-bids-pipeline/issues/333#issuecomment-848985819

hoechenberger avatar May 26 '21 18:05 hoechenberger

Hi! I have added where each of the settings in the config are used. I have created a branch so you can see. We can delete it later, when you tell me how this should be done more efficiently. Some parameters are only used in the general.md but nowhere else. Maybe in the future they will and that's why you have them.

With this we could change the website documentation files accordingly.

guiomar avatar May 26 '21 19:05 guiomar

Hi @hoechenberger this is the branch indicating where each parameter of the config file is used: https://github.com/guiomar/mne-study-template/tree/config-param-steps How would it be the best way to do it?

guiomar avatar May 28 '21 18:05 guiomar

@guiomar can you open a PR from this branch so we can more easily see the diff? 🙏

agramfort avatar May 28 '21 20:05 agramfort

I think this has been solved via #866

hoechenberger avatar Mar 07 '24 10:03 hoechenberger