externals icon indicating copy to clipboard operation
externals copied to clipboard

Published 20 hours ago • verified publisher icon mnapoli

empty message

Open staabm opened this issue 7 years ago • 4 comments

message is rendered empty, even if the plain source contains content https://externals.io/message/100697#100703 image

raw message https://externals.io/email/100703/source

staabm avatar Sep 20 '17 17:09 staabm

Thanks, this has to do with the markdown rendering:

> This commit should fix the problem https://github.com/php/php-src/commit/
> 5ef10d08ec2d0823fb21ad189dacfb43d900a0b5
>
>
> Yes! I tested 7.2.0RC2 with this patch applied and it fixes the problem.
Thank you!

Since there is no empty line it is considered as a quotation.

Not sure what to do/if there is anything to do here.

mnapoli avatar Sep 20 '17 18:09 mnapoli

But why is the message empty? Shouldn't the quote be shown anyway?

gharlan avatar Aug 20 '19 18:08 gharlan

This is because we hide quotes at the end of messages:

https://github.com/mnapoli/externals/blob/e22aa15db60840665bc67e0f9311d0e198ae40bc/res/assets/style.less#L329-L341

mnapoli avatar Aug 21 '19 06:08 mnapoli

Appears to be another case of the same issue: https://externals.io/message/108175#108176

AllenJB avatar Jan 17 '20 08:01 AllenJB