externals icon indicating copy to clipboard operation
externals copied to clipboard

Thread for message 108848 is missing messages

Open ramsey opened this issue 5 years ago • 3 comments

The following thread appears to be missing messages: https://externals.io/message/108848

This message appears (it is the start of the thread), but its content is not showing up:

  • https://news-web.php.net/php.internals/108839

The following messages do not appear at all:

  • https://news-web.php.net/php.internals/108869
  • https://news-web.php.net/php.internals/108874
  • https://news-web.php.net/php.internals/108875
  • https://news-web.php.net/php.internals/108876
  • https://news-web.php.net/php.internals/108877
  • https://news-web.php.net/php.internals/108881
  • https://news-web.php.net/php.internals/108886
  • https://news-web.php.net/php.internals/108888
  • https://news-web.php.net/php.internals/108951
  • https://news-web.php.net/php.internals/108966
  • https://news-web.php.net/php.internals/108978
  • https://news-web.php.net/php.internals/110096

ramsey avatar May 15 '20 15:05 ramsey

Hi! The first message does not appear at all because it is a quote (the whole message is a quote, follow the "view source" link: https://externals.io/email/108839/source).

Using CSS we automatically collapse the last quote to avoid having the entire thread history in every message. This doesn't work everytime, especially when authors make mistakes in their formatting.

As for the other messages, that is indeed weird! They seem to be correctly imported in the database (we can view their source: https://externals.io/email/108869/source) and attached to the correct thread (https://externals.io/message/108869 redirects to the correct thread). They just don't display at all.

Maybe parsing their content failed at some point 🤔

mnapoli avatar May 19 '20 16:05 mnapoli

Most of my messages (when I send from my laptop) include a PGP/GPG signature. Is it possible the attachment is causing problems with messages?

ramsey avatar May 19 '20 23:05 ramsey

BTW, PHP news-web used to have a similar problem (i.e., messages failing to display if they had attachments), so I had to add some code to handle the attachments.

https://github.com/php/web-news/blob/395a2f411f7eba9307f96715291c3819cfb8e6c2/article.php#L109-L140

I'm not pointing to this code as an example of how you should handle it. It's just for reference.

ramsey avatar May 19 '20 23:05 ramsey