Marija Najdova

Results 225 comments of Marija Najdova

Thanks for creating the issue and linking it to the react transition group's issue. Let's keep an eye on it to see if the maintainers will provide some feedback. I...

Thanks for the report. Can you please share a benchmark you've used for how it should behave? We use https://www.w3.org/WAI/ARIA/apg/patterns/menubutton/ as a reference for the behavior & a11y.

> in both the docs and the sandbox, when the menu is collapsed, the value of aria-controls is undefined. the correct behavior would be to use the same value as...

> it's a better practice to have the aria-controls point by ID to an element that always exists regardless, and only toggle the rendering of its contents according to whether...

> Is it because you zoom in? I experience it sometimes. I can see it on the side window on Codesandbox, can't see it on the docs 🤷‍♀️ Not really...

It's probably due to a mismatch of versions. Wold recommend updating all packages to the latest versions, or at least compatible ones.

It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or...

Hmm, I can't reproduce it with codesandbox - https://codesandbox.io/s/github/mui/material-ui/tree/master/examples/nextjs-with-typescript, nor locally. Did you noticed this locally? Could be something related to StackBlitz.

> I also removed getClasses and createShallow which were not used anywhere. > If you think it is to risky, I can add them back If they are not used...

@danilo-leal it should be fine after updating with latest master. Olivier had a PR that would fix this.