react-password-strength icon indicating copy to clipboard operation
react-password-strength copied to clipboard

bundle very large

Open yocontra opened this issue 7 years ago • 4 comments

image

this is the largest dependency in our project, but looking at the code i can't figure out why it needs to be.

sure, the frequency list is large (and maybe that should be another ticket about making a version that doesn't have that included) but there seems to be a lot of other stuff in the bundle that doesn't need to be there (node process shims, react and prop-types is bundled, etc.).

yocontra avatar Nov 07 '18 22:11 yocontra

Its expected to be larger because of zxcvbn but it sounds like maybe the dev bundle got published by accident. Will try to find some time soon to look into it

mmw avatar Nov 08 '18 12:11 mmw

Same issue here, @mmw is this expected?

danawoodman avatar Apr 01 '19 20:04 danawoodman

zxcvbn is a large library and I think thats causing the large bundle size, I haven't had time to confirm/investigate though

I'd suggest splitting your app and only using react-pass-strength where you actually need it or dynamically importing it

mmw avatar Apr 02 '19 10:04 mmw

@mmw Maybe have a lighter-weight export available that doesn't use zxcvbn? zxcvbn is great but may be overkill for most cases.

Something like react-password-strength/lite based on one of these maybe?

yocontra avatar Aug 15 '19 00:08 yocontra