krumo icon indicating copy to clipboard operation
krumo copied to clipboard

How to change skin?

Open pdelisle6180 opened this issue 5 years ago • 17 comments

Command krumo::$skin = "default" doesn't work. How does one change the skin?

pdelisle6180 avatar Apr 21 '19 02:04 pdelisle6180

Skin selection should be done in the krumo.ini

https://github.com/mmucklo/krumo/blob/master/krumo.sample.ini#L20

scottchiefbaker avatar Apr 21 '19 03:04 scottchiefbaker

Getting error messages when using krumo.ini file. [skin] selected = "default"

GET http://localhost/krumo/skins/default/bg.gif 404 (Not Found)

I verified that the file bg.gif is in the directory!

No errors when using selected = "modern"

pdelisle6180 avatar Apr 22 '19 13:04 pdelisle6180

I just tested with the default and modern skins and didn't see any errors. Are you seeing PHP errors, or browser console errors? If you navigate to that URL in your browser normally do you see something?

scottchiefbaker avatar Apr 22 '19 15:04 scottchiefbaker

Errors show up in browser console (Chrome). I am running this locally using Wamp on Windows. In spite of the errors the krumo results do show up.

pdelisle6180 avatar Apr 22 '19 16:04 pdelisle6180

krumo

pdelisle6180 avatar Apr 22 '19 16:04 pdelisle6180

krumo2

pdelisle6180 avatar Apr 22 '19 16:04 pdelisle6180

If you navigate to that URL in your browser normally do you see something?

scottchiefbaker avatar Apr 22 '19 16:04 scottchiefbaker

Yes. The krumo info shows up in spite of the error messages. I guess I'll just ignore the error messages and keep using it.

pdelisle6180 avatar Apr 22 '19 18:04 pdelisle6180

I'm not following. If you go directly to the URL it shows the image. Inside the context of a normal Krumo page that same URL doesn't load? I don't know how to help with that, as it sounds like something specific to your environment?

scottchiefbaker avatar Apr 22 '19 18:04 scottchiefbaker

krumo for some reason is looking for the images (collapsed.gif and dotted.gif) in the wrong directory when using schablon.com in krumo.ini. I just uninstalled and reinstalled using composer and problem remains. It's looking for these images in the image directory instead of looking in vendor\mmucklo\krumo\skins\schablon.com

pdelisle6180 avatar Apr 23 '19 15:04 pdelisle6180

I'm testing the schablon.com skin and it appears to be loading just fine. Can you post your krumo.ini, there might be a CSS config in there that's conflicting?

scottchiefbaker avatar Apr 23 '19 16:04 scottchiefbaker

Here is my test case using that skin.

I did a clone of this repo, and then copied the krumo.sample.ini to krumo.ini just to change the skin. Everything else is vanilla.

scottchiefbaker avatar Apr 23 '19 16:04 scottchiefbaker

I'm using a copy of the provided sample krumo.ini and uncommented the line in the [skin] section. Nothing else changed.

pdelisle6180 avatar Apr 24 '19 16:04 pdelisle6180

That is so weird. I can't recreate what you're seeing. Maybe someone else will be able to?

scottchiefbaker avatar Apr 24 '19 16:04 scottchiefbaker

@scottchiefbaker the images can be put inline inside the css files, so that there are no extra files to load, e.g.

background: url(data:image/gif;base64,R0lGODlhWgAJALMAAP///8vLy+Tk5...zCnNapVdLBAA7);

kktsvetkov avatar Dec 28 '19 20:12 kktsvetkov

Some of the skins already do that. I'd welcome patches to convert other skins to do the same.

scottchiefbaker avatar Dec 28 '19 22:12 scottchiefbaker

@scottchiefbaker I've already converted my skins in 2017 in ed1a544595e8. Do you want a pull request or you can just copy the changes made to the css files from that commit?

kktsvetkov avatar Aug 11 '20 21:08 kktsvetkov