DtcQueueBundle icon indicating copy to clipboard operation
DtcQueueBundle copied to clipboard

Add new event when job is created

Open marlenas opened this issue 7 years ago • 3 comments

Hi,

I needed a new functionality connected with adding an event when a new job is created.

I solved it on my branch. I issue a pull request, because I think that this functionality can be useful to others in the future.

Regards.

marlenas avatar Mar 26 '18 14:03 marlenas

This seems to be a reasonable request. And the implementation seems thorough enough, my one concern is the number changes required.

I'd like to review it a little bit to see if there's maybe a bit less obtrusive way.

Thanks for your PR, though.

mmucklo avatar Mar 29 '18 00:03 mmucklo

There's another issue I think - what happens when a job is created, but then "batched". Technically a job was created, but it was never saved into the queue as there was a pre-existing job that it was "batched" into.

Should there be a create event at that point? Should we have distinguishing events?

mmucklo avatar Mar 29 '18 01:03 mmucklo

I apologise for not replying the message sooner.

With reference to your message, I did not predict such a situation, but I think that these events should be distinguished.

marlenas avatar Apr 12 '18 05:04 marlenas