mmtk-core icon indicating copy to clipboard operation
mmtk-core copied to clipboard

Public API check is not always correct

Open qinsoon opened this issue 7 months ago • 1 comments

For https://github.com/mmtk/mmtk-core/pull/1165, the return value for memory_manager::is_mmtk_object is changed. However, in the run https://github.com/mmtk/mmtk-core/actions/runs/9899721290/job/27349183033, the change for is_mmtk_object is not listed.

cargo public-api diff origin/${GITHUB_BASE_REF}..1bb2d14ef68b9fb5a81f6a6ca7b941f3f22c6fe8 --deny=all
...

Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::find_prev_non_zero_value<T: mmtk::util::metadata::MetadataValue>(&self, data_addr: mmtk::util::address::Address, search_limit_bytes: usize) -> core::option::Option<mmtk::util::address::Address>
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::load_raw_byte(&self, data_addr: mmtk::util::address::Address) -> u8
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::load_raw_word(&self, data_addr: mmtk::util::address::Address) -> usize
+pub const fn mmtk::util::metadata::side_metadata::SideMetadataSpec::uses_contiguous_side_metadata(&self) -> bool
+impl core::cmp::Eq for mmtk::util::options::PlanSelector
+impl core::cmp::PartialEq for mmtk::util::options::PlanSelector
+pub fn mmtk::util::options::PlanSelector::eq(&self, other: &mmtk::util::options::PlanSelector) -> bool
+impl core::marker::StructuralPartialEq for mmtk::util::options::PlanSelector

qinsoon avatar Jul 11 '24 23:07 qinsoon