shapiq icon indicating copy to clipboard operation
shapiq copied to clipboard

Add static typechecker to pre-commits and tests

Open mmschlk opened this issue 1 year ago • 1 comments

We should add mypy static type checking. This will however need some changes in what typehints we currently are using. Especially there will be problems/changes with current np.ndarry[int] kind of hints.

  • [ ] Add mypy support to pre-commits
  • [ ] Adjust codebase typehints to make mypy test green
  • [ ] Add mypy test to CI this should be done after or also in #45
  • [ ] Edit description in CONTRIBUTING.md

mmschlk avatar Feb 13 '24 12:02 mmschlk

While this is an important issue it may be out of scope for the initial version of SHAPIQ

mmschlk avatar Mar 22 '24 15:03 mmschlk

Removed and set out of scope

mmschlk avatar Oct 28 '24 18:10 mmschlk