RcloneBrowser icon indicating copy to clipboard operation
RcloneBrowser copied to clipboard

Updated to work with Rclone v1.44

Open ghost opened this issue 6 years ago • 9 comments

ghost avatar Oct 29 '18 13:10 ghost

Thanks! Let me check few things, and I'll merge it. I'm not sure about change in utils.h for prepending space to --config. If this is fix for macOS then I think proper fix would be to add space after " config" string here: https://github.com/mmozeiko/RcloneBrowser/blob/710663876d385b0d263b967495b2a2de07e7eb4a/src/main_window.cpp#L274

Also not sure about move -> moveto change. This probably will not work in some cases.

mmozeiko avatar Oct 30 '18 08:10 mmozeiko

Thanks! Let me check few things, and I'll merge it. I'm not sure about change in utils.h for prepending space to --config. If this is fix for macOS then I think proper fix would be to add space after " config" string here:

RcloneBrowser/src/main_window.cpp

Line 274 in 7106638

QTextStream(tmp) << "#!/bin/sh\n" << GetRclone() << " config" << GetRcloneConf().join(" ") << "\n"; Also not sure about move -> moveto change. This probably will not work in some cases.

That is for macOS, yes, but I'm not as well known in this, so if you think the proper fix would be to add space, then that's probably better.

The move -> moveto is because when I tried to move a file, let's say in Movie (2009) there was a file named Movie (2009).mkv, here's an example of the structure: Movie (2009) ------Movie 20009.mkv , if I tried moving it to New Location Movie (2009), it just created a new folder in the same folder as the file, so that it was now like this: Movie (2009) ------Movie 20009.mkv (now a folder) ------------Movie 20009.mkv (the real file)

It might be something I did wrong, but it worked when move was changed to moveto.

ghost avatar Oct 30 '18 10:10 ghost

@mmozeiko I enjoy a lot RcloneBrowser. Unfortunaletlly I am not able to propose PR not to compile it. Could we have an official update release? TIA CTone

caspertone2003 avatar Nov 11 '18 20:11 caspertone2003

@jonaknop @MostHated

I can confirm what MostHated reported. Same issue here (use W10 x64). Tried all proposed workarounds. Simply, it seems unable to use a custom location of config and furthermore is unable to configure the standard location either.

CTone

caspertone2003 avatar Nov 11 '18 22:11 caspertone2003

@jonaknop @mmozeiko

As I noticed something strange, as I used this version while I kept the official one (1.2) (each on different directories), the second one, when opening settings, there were some values there ... of the official one.

Searching in the registry i found out two things a) rclonebrowser is not truly portable as it stores its parameters in the registry b) seems that there some issue with the storage in the registry, see image.

captura

caspertone2003 avatar Nov 11 '18 23:11 caspertone2003

Hello!. I am a complete zero in programming, and do not know English), could you compile your branch under windows 32 and 64 bit. I would be very grateful!

Bagmetalex avatar Nov 24 '18 16:11 Bagmetalex

does this work for rclone 1.41 from ubuntu 18.10 ?

felisucoibi avatar Nov 25 '18 02:11 felisucoibi

@mmozeiko would it be possible to get this merged?

ordinarygulp avatar Feb 21 '19 05:02 ordinarygulp

If you want to contact the developer, leave him a message on reddit. He is active on that site. Here is his profile. https://www.reddit.com/user/martins_m

He doesn't really hang out here anymore.

EricTheRed1 avatar Feb 22 '19 04:02 EricTheRed1